Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

task: moving docker to be only multi #51

Merged
merged 22 commits into from
Nov 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
95e4b8f
task: moving docker to be only multi
paganotoni Nov 20, 2021
b64abe0
task: making the command actually skip the Docker files generator
paganotoni Nov 20, 2021
aae6116
Merge branch 'development' of https://github.com/gobuffalo/cli into t…
paganotoni Nov 20, 2021
bbfae2d
Merge pull request #50 from gobuffalo/development
paganotoni Nov 25, 2021
bdbd528
Bump actions/stale from 3 to 4
dependabot[bot] Nov 25, 2021
219aa93
adding test for dockerfile
paganotoni Nov 25, 2021
1166f0a
Merge pull request #53 from gobuffalo/dependabot/github_actions/actio…
paganotoni Nov 25, 2021
9db3b51
Merge branch 'main' of https://github.com/gobuffalo/cli into task-sin…
paganotoni Nov 25, 2021
a89dc3b
fixing broken tests
paganotoni Nov 25, 2021
747690d
adding none as the VCS for the new command tests
paganotoni Nov 25, 2021
bf8eb00
adding go mod download to the new command
paganotoni Nov 25, 2021
f59bf65
removing debugging line
paganotoni Nov 26, 2021
e623473
moving to require
paganotoni Nov 26, 2021
92b51d9
adding integration tests next to the new command
paganotoni Nov 26, 2021
f92aab9
adding a bit more of documentation
paganotoni Nov 26, 2021
4ec1033
changing cli detection a bit
paganotoni Nov 26, 2021
b56057b
adding build integration tests
paganotoni Nov 26, 2021
dc3d695
changing the signature for the method that runs buffalo commands for …
paganotoni Nov 26, 2021
8856964
reverting to old signature of the helper
paganotoni Nov 26, 2021
d1a813b
fixing it back
paganotoni Nov 26, 2021
a8aba5e
adding -f and renaming just in case
paganotoni Nov 26, 2021
a9f6721
adding -p 1 on integration tests
paganotoni Nov 26, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v3
- uses: actions/stale@v4
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: "This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days."
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,8 @@ jobs:

- name: Test
run: |
go mod tidy -v
go test -tags "sqlite" -cover ./...

- name: Integration tests
run: |
go test -p 1 -tags "sqlite,integration" -cover ./...
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ require (
github.com/spf13/pflag v1.0.5
github.com/spf13/viper v1.9.0
github.com/stretchr/testify v1.7.0
golang.org/x/mod v0.4.2
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/tools v0.1.7
gopkg.in/yaml.v2 v2.4.0
Expand Down
58 changes: 58 additions & 0 deletions internal/cmd/build_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
//go:build integration
// +build integration

package cmd

import (
"os"
"path/filepath"
"testing"

"github.com/gobuffalo/cli/internal/testhelpers"
"github.com/stretchr/testify/require"
)

func TestBuild(t *testing.T) {
r := require.New(t)
r.NoError(testhelpers.EnsureBuffaloCMD(t))

tcases := []struct {
name string
newargs []string
appname string
}{
{
name: "nominal",
newargs: []string{"new", "nominal", "-f", "--skip-webpack", "--vcs", "none"},
appname: "nominal",
},
{
name: "api",
newargs: []string{"new", "api", "-f", "--api", "--vcs", "none"},
appname: "api",
},
{
name: "sqlite",
newargs: []string{"new", "sqlite", "-f", "--skip-webpack", "--db-type=sqlite3", "--vcs", "none"},
appname: "sqlite",
},
}

for _, v := range tcases {
t.Run(v.name, func(tx *testing.T) {
r := require.New(tx)

dir := os.TempDir()
os.Chdir(filepath.Join(dir))

out, err := testhelpers.RunBuffaloCMD(t, v.newargs)
tx.Log(out)
r.NoError(err)

os.Chdir(filepath.Join(dir, v.appname))
out, err = testhelpers.RunBuffaloCMD(t, []string{"build"})
tx.Log(out)
r.NoError(err)
})
}
}
83 changes: 0 additions & 83 deletions internal/cmd/internal/integration/build_test.go

This file was deleted.

43 changes: 0 additions & 43 deletions internal/cmd/internal/integration/new_test.go

This file was deleted.

Loading