Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Generate embed.go files with hot reload enabled #60

Merged
merged 17 commits into from
Nov 29, 2021
Merged

Generate embed.go files with hot reload enabled #60

merged 17 commits into from
Nov 29, 2021

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Nov 27, 2021

This PR updates some of the existing tests and adds templates for the new embed.go files that allow for hot reloading. This is the follow up to

gobuffalo/buffalo#2180

@fasmat fasmat marked this pull request as ready for review November 27, 2021 23:38
@fasmat fasmat changed the title Improve integration testing and add fixers for 0.17.x -> 0.18.x Refactor existing tests to use genny instead of fixtures Nov 27, 2021
@fasmat fasmat changed the title Refactor existing tests to use genny instead of fixtures Generate embed.go files with hot reload enabled Nov 27, 2021
@sio4
Copy link
Member

sio4 commented Nov 28, 2021

LGTM! tested along with updated gobuffalo/buffalo#2180

@fasmat
Copy link
Member Author

fasmat commented Nov 28, 2021

@paganotoni This PR is now ready to be merged 😄

@fasmat fasmat mentioned this pull request Nov 28, 2021
@sio4 sio4 mentioned this pull request Nov 29, 2021
14 tasks
@paganotoni paganotoni merged commit 9a97761 into gobuffalo:development Nov 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants