Pluralization and capitalization issues

[dvli2007]

Pluralize() should in theory pluralize a name while maintaining the cases. For example, FooBar -> FooBars.

However, there are a few cases where the pluralization produces unintentional lowercasing.

1. Half -> halves
   It seems that when the whole word matches an item in the singularToPlural map, the entire word gets converted in lowercase. On the contrary, this seems to behave correctly when a singular word is attached to another one, such as the case of LemonHalf -> LemonHalves.

2. SmartPerson -> Smartpeople
   It seems that when the suffix matches one of the pluralRules, the entire matched portion remains lowercase.

3. SuperbOx -> Superboxes
   It seems that camel-casing is not respected for breaking up words. In fact, the pluralRules seem to be applied first (box -> boxes) before the singularToPlural rules (ox -> oxen). In fact, it seems that when ox is attached to another word, it will never be changed to oxen (example: big_ox -> big_oxes).

Overall, having consistent behavior here is important as this package is used by gobuffalo/pop for auto-generating table names from camel-case structs. Happy to help discuss potential solutions!

[markbates]

PRs welcome. Please. :)

…

----------- Mark Bates

On Apr 13, 2019, 1:31 AM -0400, dvli2007 ***@***.***>, wrote: Pluralize() should in theory pluralize a name while maintaining the cases. For example, FooBar -> FooBars. However, there are a few cases where the pluralization produces unintentional lowercasing. 1. > Half -> halves It seems that when the whole word matches an item in the singularToPlural map, the entire word gets converted in lowercase. On the contrary, this seems to behave correctly when a singular word is attached to another one, such as the case of LemonHalf -> LemonHalves. 2. > SmartPerson -> SmartpeopleIt seems that when the suffix matches one of thepluralRules`, the entire matched portion remains lowercase. 3. > SuperbOx -> Superboxes It seems that camel-casing is not respected for breaking up words. In fact, the pluralRules seem to be applied first (box -> boxes) before the singularToPlural rules (ox -> oxen). Overall, having consistent behavior here is important as this package is used by gobuffalo/pop for auto-generating table names from camel-case structs. Happy to help discuss potential solutions! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[pgier]

PR #29 should fix the big_ox -> big_oxes issue

[rameshgkwd05]

The above PR #29 covers multi-words.
But what about general words, those should be pluralized according to this Grammarly article: https://www.grammarly.com/blog/plural-nouns/

Maybe a more elegant suffix-function is needed.

[sio4]

Thank you for reporting the issue. it was fixed by #59