Only run compatible down migrations #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Previously `Migrator.Down()` would run incompatible migrations. This patch addresses that issue by checking if the migration is compatible with the current translator/database before applying it. Filtering is required as counting is used to filter out already run down migrations and migrations that have not yet been applied.
aeneasr
force-pushed
the
down-only-compatible
branch
from
5f5c435
to
c3a39a1
Compare
|
Same SQLite failure as with my other PR - is it possible that this is CI-related? |
|
Yeah, sometimes the CI tests for SQLite on Windows got stuck. I've trigger a new build. |
stanislas-m
approved these changes
Jun 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Migrator.Down()would run incompatible migrations. This patch addresses that issue by checking if the migration is compatible with the current translator/database before applying it.