Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load SQLite instrumentation only when build tag present #601

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Load SQLite instrumentation only when build tag present #601

merged 1 commit into from
Oct 19, 2020

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 19, 2020

No description provided.

@aeneasr aeneasr added the bug Something isn't working label Oct 19, 2020
@aeneasr aeneasr requested a review from a team as a code owner October 19, 2020 11:39
@aeneasr aeneasr self-assigned this Oct 19, 2020
@aeneasr
Copy link
Member Author

aeneasr commented Oct 19, 2020

I forgot to prevent the SQLite driver from loading when the sqlite tag is missing in instrumentation. This patch resolves that! Sorry about the oversight. I added tests so this doesn't happen again.

@aeneasr aeneasr changed the base branch from master to development October 19, 2020 11:56
@aeneasr aeneasr merged commit 9d4de46 into development Oct 19, 2020
@aeneasr aeneasr deleted the fix-sqlite-build branch October 19, 2020 11:56
@aeneasr
Copy link
Member Author

aeneasr commented Oct 19, 2020

Thank you for the quick review!

@zepatrik zepatrik mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislas-m stanislas-m stanislas-m approved these changes

Assignees

@aeneasr aeneasr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeneasr @stanislas-m