hotfix for ignored --env
flag issue (#269)
#727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully sure if the issue happen again or if the previous patch does not fill all the cases. Anyway, the same issue happens again:
Issue Description
Even though the
--env
(or short-e
) flag is given, the command just follows the environment variable.Root Cause
It seems like the issue was caused by confusing naming and the behavior of
PersistantPreRun
field ofcobra.Command
andPersistentFlags()
function. I added a detailed comment on the code so easy to check later.(One unrelated commit is also included :-)
Related: #282
Fixes #269