[RFC] Support default value for optional environment variables #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the logic for loading a value from parsing the value, that way we only need to check if the env var is required in one place.
Prius helps us ensure that our application always boots with the required state. However in large applications with multiple contributors, this can cause a configuration error in an unrelated component to break the entire application. Providing a default value allows contributors to safely introduce new configuration without worrying if the application breaks. For example: ```ruby Prius.get(:my_worker_pool, type: int, required: false, default: 0) ``` It also means that boolean flags that are optional can be made to have a default value of `false` rather than `nil`. Note: This change _does not_ allow you to specify a default value for required config, for obvious reasons.
ameykusurkar
force-pushed
the
default-values
branch
from
aca021f
to
a4603a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prius helps us ensure that our application always boots with the
required state. However in large applications with multiple contributors,
this can cause a configuration error in an unrelated component to break
the entire application.
Providing a default value allows contributors to safely introduce new
configuration without worrying if the application breaks. For example:
It also means that boolean flags that are optional can be made to have a
default value of
trueorfalse, rather thannil.Note: This change does not allow you to specify a default value for
required config, for obvious reasons.