Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout on metric HTTP requests #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add timeout on metric HTTP requests #70

wants to merge 1 commit into from

Commits on Jul 21, 2021

  1. Add timeout on HTTP requests 

    By default, neither webrick or rack will timeout http requests. This
means that if a request to `/metrics` or `/queue/metrics` takes longer
than the `scrape_timeout`, we risk backing up requests for metrics and
eventually overloading the worker.

This adds rack-timeout to force the request to exit after the default
timeout of 30 seconds (but it can be changed either by setting
`RACK_TIMEOUT_SERVICE_TIMEOUT` to a different value or by the
`--metrics-request-timeout` options flag when starting the worker).
    @ivgiuliani
    ivgiuliani committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    62421c8 View commit details
    Browse the repository at this point in the history