Skip to content

Commit

Permalink
Removed Mutating Admission Webhook
Browse files Browse the repository at this point in the history
Removed priority-injector.workloads.gocardless.com

We aren't using this feature anymore, we might revamp the design for
this in the future. However for now we want to remove this configuration
and potential all code related with it.

Additional context, this has been a blocker for other projects that
we're doing.

They was never a configuration flag to enable this settings, however you
were able to opt-in via labels in the relevant namespace. See label
theatre_priority_injector

After this PR, our some of the acceptance test will be broken, that I
will use as guide to remove the rest of the relevant code
  • Loading branch information
rnaveiras committed Jun 12, 2023
1 parent d54d6a6 commit 6dc141d
Showing 1 changed file with 0 additions and 30 deletions.
30 changes: 0 additions & 30 deletions config/base/webhooks/workloads.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,36 +30,6 @@ webhooks:
- consoles
scope: '*'
sideEffects: None
- admissionReviewVersions: ["v1", "v1beta1"]
clientConfig:
caBundle: Cg==
service:
name: theatre-workloads-manager
namespace: theatre-system
path: /mutate-pods
port: 443
name: priority-injector.workloads.crd.gocardless.com
namespaceSelector:
matchExpressions:
- key: control-plane
operator: DoesNotExist
# Only run the webhook when the namespace has the necessary label. It
# prevents running the mutating webhook for critical namespaces like
# kube-system and theatre-system so the system can recover
# automatically if the workload controller goes down.
- key: theatre-priority-injector
operator: Exists
rules:
- apiGroups:
- ''
apiVersions:
- v1
operations:
- CREATE
resources:
- pods
scope: '*'
sideEffects: None
---
apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
Expand Down

0 comments on commit 6dc141d

Please sign in to comment.