expose metrics for sidecar container #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will expose metrics for the sidecar container. We use ports 8080 and 8090 as these are the metrics ports for PubSubTle and SideWrap respectively. This should allow us to scrape metrics about the health of the two containers that power console session recording.
VSpike
approved these changes
Dec 16, 2021
benwh
reviewed
Dec 16, 2021
There was a problem hiding this comment.
Generally the convention is to start the ports at 9100 and above
https://github.com/prometheus/prometheus/wiki/Default-port-allocations
No big deal here as it's a containerised environment, but port 8080 does slightly violate the "principle of least surprise" 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will expose metrics for the sidecar container. We use ports 8080
and 8090 as these are the metrics ports for PubSubTle and SideWrap
respectively.
This should allow us to scrape metrics about the health of the
two containers that power console session recording.