Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert gocardless/theatre to GitHub Actions #267

Merged

Conversation

sam-robson
Copy link
Contributor

@sam-robson sam-robson commented Oct 28, 2022

Pipeline migrated from Circle CI 🎉

Manual steps

Perform the follow steps to complete the migration:

gocardless/theatre/build-integration

  • Ensure secret is available: ${{ secrets.CIRCLE_CI_SSH_KEY }}
  • Ensure secret is available: ${{ secrets.CIRCLE_CI_KNOWN_HOSTS }}
  • Ensure environment variable is updated: GITHUB_TOKEN

Raúl updated:

  • Update go version to 1.19.3. Same that we had in circle.
  • Webhooks are sent as POST requests, with Content-Type: application/json,
    with an AdmissionReview API object in the admission.k8s.io API group
    serialized to JSON as the body.

Webhooks can specify what versions of AdmissionReview objects they
accept with the admissionReviewVersions field in their configuration:

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
webhooks:
- name: foo.gocardless.com
  admissionReviewVersions: ["v1", "v1beta1"]
  • actions/setup-go@4 enabled caching by default. That should speed up all the go dependencies.

Integration testing is failing

The following integration test is also failing:

Summarizing 4 Failures:

[Fail] Acceptance Consoles [It] Happy path 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:118

[Fail] Acceptance Consoles Runner interface [It] Happy path 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:242

[Fail] Acceptance Consoles [It] Deleting a console template 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:415

[Fail] Acceptance Consoles [It] Deleting a job 
/home/runner/work/theatre/theatre/cmd/workloads-manager/acceptance/acceptance.go:460

Ran 8 of 8 Specs in 16.624 seconds
FAIL! -- 4 Passed | 4 Failed | 0 Pending | 0 Skipped

I had runed this locally, and I consistently get similar errors. So I think it is best to get this change in and handle the acceptance tests in a following PR

  • I haven't tested the release process, which refers to the variables that Sam mentioned here. However, at this point, we aren't going to a release; I can sort that out in a follow-up PR.

@sam-robson sam-robson force-pushed the convert-gocardless-theatre-to-actions-20221028-092655 branch 5 times, most recently from 79a4868 to 39421f9 Compare October 28, 2022 10:41
@rnaveiras rnaveiras force-pushed the convert-gocardless-theatre-to-actions-20221028-092655 branch from 39421f9 to 422fb40 Compare June 12, 2023 14:05
Same version that we had in the circle configuration, after rebased this
branch from master
@rnaveiras rnaveiras force-pushed the convert-gocardless-theatre-to-actions-20221028-092655 branch from 3eb5799 to 3c20cc0 Compare June 12, 2023 14:31
Webhooks are sent as POST requests, with Content-Type: application/json,
with an AdmissionReview API object in the admission.k8s.io API group
serialized to JSON as the body.

Webhooks can specify what versions of AdmissionReview objects they
accept with the admissionReviewVersions field in their configuration:

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
webhooks:
- name: foo.gocardless.com
  admissionReviewVersions: ["v1", "v1beta1"]
This should be speed up the work
@rnaveiras rnaveiras force-pushed the convert-gocardless-theatre-to-actions-20221028-092655 branch from 3c20cc0 to 253588a Compare June 12, 2023 14:49
Copy link
Contributor

@rnaveiras rnaveiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in the PR

@rnaveiras rnaveiras merged commit d54d6a6 into master Jun 12, 2023
@rnaveiras rnaveiras deleted the convert-gocardless-theatre-to-actions-20221028-092655 branch June 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants