Removed Mutating Admission Webhook for pod priorities #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnaveiras
changed the title
rnaveiras
force-pushed
the
rnaveiras-remove-pod-priority-webhook
branch
3 times, most recently
from
ec6b2d3
to
d5a7762
Compare
Removed priority-injector.workloads.gocardless.com We aren't using this feature anymore, we might revamp the design for this in the future. However for now we want to remove this configuration and potential all code related with it. Additional context, this has been a blocker for other projects that we're doing. They was never a configuration flag to enable this settings, however you were able to opt-in via labels in the relevant namespace. See label theatre_priority_injector After this PR, our some of the acceptance test will be broken, that I will use as guide to remove the rest of the relevant code
Removed all the relevant code that is part of the mutate webhook that takes care of update the pod priority.
rnaveiras
force-pushed
the
rnaveiras-remove-pod-priority-webhook
branch
from
c781a25
to
5ec35ac
Compare
DragosDumitrache
approved these changes
Jun 14, 2023
rnaveiras
added a commit
that referenced
this pull request
Jun 14, 2023
After removed pod priority mutate webhook these docs are not relevant anymore. #276 Signed-off-by: Raúl Naveiras <me@raulnaveiras.com>
rnaveiras
added a commit
that referenced
this pull request
Jun 14, 2023
Update documentation after #276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed priority-injector.workloads.gocardless.com
We aren't using this feature anymore; we might revamp this design. However, we want to remove this configuration and potentially all related code.
In additional context, this has been a blocker for other projects that we're doing.
They were never a configuration flag to enable this setting. However, you could opt-in via labels in the relevant namespace. See label theatre_priority_injector.
After this PR, some of the acceptance tests will be broken, which I will use as a guide to removing the rest of the relevant code.