Add Prometheus build_info metrics #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnaveiras
force-pushed
the
prometheus-info
branch
from
0b2ef96
to
25a6d1d
Compare
rnaveiras
force-pushed
the
prometheus-info
branch
from
25a6d1d
to
259f13d
Compare
```
theatre_build_info{commit="none",goarch="arm64",goos="linux",goversion="go1.20.5",version="dev"} 1
```
This is a good practice that should be in all our binaries
rnaveiras
force-pushed
the
prometheus-info
branch
from
259f13d
to
7960ff1
Compare
DragosDumitrache
approved these changes
Jun 16, 2023
|
Thanks @DragosDumitrache You can see an example of this in other workloads https://thanos.gocardless.io/graph?g0.expr=prometheus_build_info&g0.tab=1&g0.stacked=0&g0.range_input=1h&g0.max_source_resolution=0s&g0.deduplicate=1&g0.partial_response=0&g0.store_matches=%5B%5D |
rnaveiras
added a commit
that referenced
this pull request
Jun 26, 2023
This PR removed this code by mistake #300
rnaveiras
added a commit
that referenced
this pull request
Jun 26, 2023
This pull request restores the code removed by mistake in the `secretsinjector_webhook`. Now the metrics are registered again with the `Prometheus.Registry`, and should be back to be reported. See details here #300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is is a best practice with the Prometheus community and will help track versions at runtime.