Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI dependencies and Kustomize deprecations #335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benwh
Copy link
Contributor

@benwh benwh commented Aug 19, 2024

Here's a couple of fixes that we've got in our fork. Details in commit messages.

As per instructions at https://github.com/kubernetes-sigs/controller-runtime/tree/main/tools/setup-envtest

This should prevent current and future breakage.
When running `kustomize build`, we currently see some warnings. Get rid
of these by using the more modern replacements. See [docs][0].

```
Warning: 'commonLabels' is deprecated. Please use 'labels' instead.
Warning: 'vars' is deprecated. Please use 'replacements' instead.
```

[0]: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant