Properly report validation errors from inline fields in strict mode #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
+ Coverage 78.39% 78.47% +0.07%
==========================================
Files 12 12
Lines 3421 3419 -2
==========================================
+ Hits 2682 2683 +1
+ Misses 505 502 -3
Partials 234 234 |
|
From the next time, if it is still under development, Please use Draft PR or add WIP to the title :) . |
|
@goccy This PR is ready for review. |
goccy
reviewed
Aug 10, 2021
|
Thank you very much for the quick reviews! |
|
Thank you for the contribution ! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second half of #244...