Escape single quotes in single-quoted string #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to YAML specification, single quotes must be repeated in a single-quoted scalar. https://yaml.org/spec/1.2.2/#732-single-quoted-style Fixes goccy#255
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 76.32% 76.44% +0.12%
==========================================
Files 12 12
Lines 4194 4216 +22
==========================================
+ Hits 3201 3223 +22
Misses 759 759
Partials 234 234 |
goccy
reviewed
Oct 12, 2021
ast/ast.go
Outdated
| // https://yaml.org/spec/1.2.2/#732-single-quoted-style | ||
| func escapeSingleQuote(s string) string { | ||
| var sb strings.Builder | ||
| sb.Grow(2+strings.Count(s, "'")*2) |
There was a problem hiding this comment.
Suggested change
| sb.Grow(2+strings.Count(s, "'")*2) | |
| growLen := len(s)+2+strings.Count(s, "'")*2 | |
| sb.Grow(growLen) |
There was a problem hiding this comment.
Thanks for spotting this!
As I'm reading the code again, the length should be sum of
len(s)for the original string (including'characters)2for the opening and closing'strings.Count(s, "'")(without the*2) as each'is already included inlen(s)once
I've added a commit to fix the calculation.
Thanks goccy for review and suggestion.
|
Thank you for adding test case to
ignore:
- ast |
ast package did not have any tests previously and a new test was added. The codecov tool computes that code coverage has dropped by 15% even though a new test was added. Adding ast to ignore list as a workaround so that the pull request can be merged. Thanks goccy for the suggestion.
|
Added the codecov ignore. Thanks for the suggestion! |
|
Thank you for the contribution ! LGTM ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to YAML specification, single quotes must be repeated
in a single-quoted scalar.
https://yaml.org/spec/1.2.2/#732-single-quoted-style
Fixes #255