-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve defaults while decoding nested structs #260
Conversation
Al2Klimov
commented
Oct 14, 2021
•
edited
Loading
edited
The new tests are failing, but due to the implementation:
With gopkg.in/yaml.v3 ...
... they don't fail. |
@goccy Now it should work! |
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 76.44% 76.48% +0.03%
==========================================
Files 12 12
Lines 4216 4222 +6
==========================================
+ Hits 3223 3229 +6
Misses 759 759
Partials 234 234 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@Al2Klimov |
@goccy Done. |
@Al2Klimov Thank you ! LGTM |