scanner: fix position calculation for literal, folded and raw folded strings #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 75.63% 75.63%
=======================================
Files 13 13
Lines 4359 4359
=======================================
Hits 3297 3297
Misses 819 819
Partials 243 243 |
|
Thank you for your great PR !!! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach to calculating the column is not ideal from an allocations perpective, but is similar to other calculations in the code base that do a temporary
[]rune→stringconversion. I would prefer to retain an offset field instead, but that is a more invasive change.The setting of
token.Position.IndentNumis left as is since it's not clear to me what that is there for; the field is never read in the code base and so is apparently not used internally (removal does not affect tests, though external client code may be using it for something).Fixes #326.
Please take a look.