Don't trim all space characters in SequenceNode.blockStyleString #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes goccy#356. The code would have removed more spaces than it added. A better solution long-term would probably be to add a specialized method to StringNode to not add the prefix in the first place.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 75.37% 75.37%
=======================================
Files 13 13
Lines 4545 4545
=======================================
Hits 3426 3426
Misses 864 864
Partials 255 255 |
goccy
reviewed
Mar 19, 2023
| @@ -1570,8 +1570,9 @@ func (n *SequenceNode) blockStyleString() string { | |||
| diffLength := len(splittedValues[0]) - len(trimmedFirstValue) | |||
| if len(splittedValues) > 1 && value.Type() == StringType || value.Type() == LiteralType { | |||
| // If multi-line string, the space characters for indent have already been added, so delete them. | |||
| prefix := space + " " | |||
There was a problem hiding this comment.
Suggested change
| prefix := space + " " | |
| firstContentLineSpaceNum := len(splittedValues[1]) - len(strings.TrimLeft(splittedValues[1], " ")) | |
| prefix := strings.Repeat(" ", firstContentLineSpaceNum) |
There was a problem hiding this comment.
I felt it would be better to calculate using the number of spaces in the first line
There was a problem hiding this comment.
That does not work if the first line is empty. I have added a test case with the first line empty. I've also discovered a separate issue #366.
The indentation level in a block scalar is determined by the first non-empty line.
goccy
approved these changes
Mar 21, 2023
Racer159
referenced
this pull request
in zarf-dev/zarf
Mar 31, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | @​defense-unicorns/unicorn-ui | [`0.0.37` -> `0.0.42`](https://renovatebot.com/diffs/npm/@defense-unicorns%2funicorn-ui/0.0.37/0.0.42) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [@docusaurus/core](https://github.com/facebook/docusaurus) | [`2.3.1` -> `2.4.0`](https://renovatebot.com/diffs/npm/@docusaurus%2fcore/2.3.1/2.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@docusaurus/module-type-aliases](https://github.com/facebook/docusaurus) | [`2.3.1` -> `2.4.0`](https://renovatebot.com/diffs/npm/@docusaurus%2fmodule-type-aliases/2.3.1/2.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@docusaurus/preset-classic](https://github.com/facebook/docusaurus) | [`2.3.1` -> `2.4.0`](https://renovatebot.com/diffs/npm/@docusaurus%2fpreset-classic/2.3.1/2.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@docusaurus/theme-mermaid](https://github.com/facebook/docusaurus) | [`2.3.1` -> `2.4.0`](https://renovatebot.com/diffs/npm/@docusaurus%2ftheme-mermaid/2.3.1/2.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | [@playwright/test](https://playwright.dev) ([source](https://github.com/Microsoft/playwright)) | [`1.31.2` -> `1.32.1`](https://renovatebot.com/diffs/npm/@playwright%2ftest/1.31.2/1.32.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@sveltejs/kit](https://kit.svelte.dev) ([source](https://github.com/sveltejs/kit)) | [`1.12.0` -> `1.15.0`](https://renovatebot.com/diffs/npm/@sveltejs%2fkit/1.12.0/1.15.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | [`5.55.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.55.0/5.57.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | [`5.55.0` -> `5.57.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.55.0/5.57.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [actions/checkout](https://github.com/actions/checkout) | `v3.4.0` -> `v3.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | minor | | [anchore/sbom-action](https://github.com/anchore/sbom-action) | `v0.13.3` -> `v0.13.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | patch | | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | [`8.36.0` -> `8.37.0`](https://renovatebot.com/diffs/npm/eslint/8.36.0/8.37.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) | [`8.7.0` -> `8.8.0`](https://renovatebot.com/diffs/npm/eslint-config-prettier/8.7.0/8.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [github.com/defenseunicorns/syft](https://github.com/defenseunicorns/syft) | `v0.75.0-DU` -> `v0.75.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | replace | patch | | [github.com/docker/cli](https://github.com/docker/cli) | `v23.0.1+incompatible` -> `v23.0.2+incompatible` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/fluxcd/helm-controller/api](https://github.com/fluxcd/helm-controller) | `v0.31.1` -> `v0.31.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/fluxcd/source-controller/api](https://github.com/fluxcd/source-controller) | `v0.36.0` -> `v0.36.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/go-logr/logr](https://github.com/go-logr/logr) | `v1.2.3` -> `v1.2.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/goccy/go-yaml](https://github.com/goccy/go-yaml) | `v1.10.0` -> `v1.10.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/moby/moby](https://github.com/moby/moby) | `v23.0.1+incompatible` -> `v23.0.2+incompatible` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github.com/pterm/pterm](https://github.com/pterm/pterm) | `v0.12.56` -> `v0.12.57` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | patch | | [github/codeql-action](https://github.com/github/codeql-action) | `v2.2.7` -> `v2.2.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | patch | | [material-symbols](https://marella.github.io/material-symbols/demo/) ([source](https://github.com/marella/material-symbols)) | [`0.5.0` -> `0.5.3`](https://renovatebot.com/diffs/npm/material-symbols/0.5.0/0.5.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [nodemon](https://nodemon.io) ([source](https://github.com/remy/nodemon)) | [`2.0.21` -> `2.0.22`](https://renovatebot.com/diffs/npm/nodemon/2.0.21/2.0.22) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `v2.1.2` -> `v2.1.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | patch | | [playwright](https://playwright.dev) ([source](https://github.com/Microsoft/playwright)) | [`1.31.2` -> `1.32.1`](https://renovatebot.com/diffs/npm/playwright/1.31.2/1.32.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [prettier](https://prettier.io) ([source](https://github.com/prettier/prettier)) | [`2.8.5` -> `2.8.7`](https://renovatebot.com/diffs/npm/prettier/2.8.5/2.8.7) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [prettier-plugin-svelte](https://github.com/sveltejs/prettier-plugin-svelte) | [`2.9.0` -> `2.10.0`](https://renovatebot.com/diffs/npm/prettier-plugin-svelte/2.9.0/2.10.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [quicktype](https://github.com/quicktype/quicktype) | [`23.0.17` -> `23.0.19`](https://renovatebot.com/diffs/npm/quicktype/23.0.17/23.0.19) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [sass](https://github.com/sass/dart-sass) | [`1.59.3` -> `1.60.0`](https://renovatebot.com/diffs/npm/sass/1.59.3/1.60.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [serde_json](https://github.com/serde-rs/json) | `1.0.94` -> `1.0.95` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize) | `v0.12.1` -> `v0.13.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | require | minor | | [svelte](https://svelte.dev) ([source](https://github.com/sveltejs/svelte)) | [`3.57.0` -> `3.58.0`](https://renovatebot.com/diffs/npm/svelte/3.57.0/3.58.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [typescript](https://www.typescriptlang.org/) ([source](https://github.com/Microsoft/TypeScript)) | [`5.0.2` -> `5.0.3`](https://renovatebot.com/diffs/npm/typescript/5.0.2/5.0.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | --- ### Release Notes <details> <summary>facebook/docusaurus</summary> ### [`v2.4.0`](https://github.com/facebook/docusaurus/blob/HEAD/CHANGELOG.md#​240-2023-03-23) [Compare Source](https://github.com/facebook/docusaurus/compare/v2.3.1...v2.4.0) ##### :rocket: New Feature - `docusaurus-plugin-content-docs`, `docusaurus-theme-classic` - [#​8236](https://github.com/facebook/docusaurus/pull/8236) feat(content-docs): add support for sidebar item category/link descriptions in generated index page ([@​ZarakiKanzaki](https://github.com/ZarakiKanzaki)) - `docusaurus-theme-classic` - [#​8708](https://github.com/facebook/docusaurus/pull/8708) feat(theme): allow to load a Docusaurus page with theme from query-string: ?docusaurus-theme=dark ([@​slorber](https://github.com/slorber)) - [#​8616](https://github.com/facebook/docusaurus/pull/8616) feat(theme): add ability to translate navbar+footer logo alt text ([@​Mysterious-Dev](https://github.com/Mysterious-Dev)) - `docusaurus-remark-plugin-npm2yarn` - [#​8690](https://github.com/facebook/docusaurus/pull/8690) feat(npm-to-yarn): add support for PnPm and custom converters ([@​armano2](https://github.com/armano2)) - `docusaurus` - [#​8677](https://github.com/facebook/docusaurus/pull/8677) feat(core): add script env variables: NODE_ENV + BABEL_ENV + DOCUSAURUS_CURRENT_LOCALE (temporary i18n workaround) ([@​slorber](https://github.com/slorber)) - `docusaurus-theme-classic`, `docusaurus-theme-common` - [#​8674](https://github.com/facebook/docusaurus/pull/8674) feat(theme-classic): respect `prefers-reduced-motion: reduce` mediaquery, bump Infima to alpha.43 ([@​slorber](https://github.com/slorber)) - `docusaurus-theme-translations` - [#​8668](https://github.com/facebook/docusaurus/pull/8668) feat(theme-translations): add Hungarian theme translations ([@​trueqap](https://github.com/trueqap)) - [#​8631](https://github.com/facebook/docusaurus/pull/8631) feat(theme-translations): add Norwegian (Bokmål) theme translation ([@​dr0nn1](https://github.com/dr0nn1)) - `docusaurus-theme-common` - [#​8656](https://github.com/facebook/docusaurus/pull/8656) feat(theme-common): allow passing a string for details summary ([@​pReya](https://github.com/pReya)) - `docusaurus-plugin-google-gtag` - [#​8620](https://github.com/facebook/docusaurus/pull/8620) feat(gtag-plugin): gtag should support multiple tracking ids, notably for the UA => GA4 transition ([@​slorber](https://github.com/slorber)) ##### :bug: Bug Fix - `docusaurus-theme-classic` - [#​8803](https://github.com/facebook/docusaurus/pull/8803) fix(theme): codeblock buttons should be kept on the right when using RTL locale ([@​Vishruta-Patil](https://github.com/Vishruta-Patil)) - [#​8615](https://github.com/facebook/docusaurus/pull/8615) fix(theme): improve color toggle when using dark navbar ([@​dewanshDT](https://github.com/dewanshDT)) - [#​8699](https://github.com/facebook/docusaurus/pull/8699) fix(theme-classic): fix tab focus bug in dropdown ([#​8697](https://github.com/facebook/docusaurus/issues/8697)) ([@​kagankan](https://github.com/kagankan)) - `docusaurus-theme-classic`, `docusaurus-theme-common` - [#​8801](https://github.com/facebook/docusaurus/pull/8801) fix(theme): allow tabs children to be falsy ([@​Josh-Cena](https://github.com/Josh-Cena)) - `docusaurus-theme-common`, `docusaurus-theme-search-algolia` - [#​8757](https://github.com/facebook/docusaurus/pull/8757) fix(search): search page should react to querystring changes + cleanup/refactor ([@​slorber](https://github.com/slorber)) - `docusaurus` - [#​8746](https://github.com/facebook/docusaurus/pull/8746) fix(core): baseUrl error banner link anchor case ([@​slorber](https://github.com/slorber)) - `docusaurus-theme-translations` - [#​8744](https://github.com/facebook/docusaurus/pull/8744) fix(theme-translations): fix wrong arabic words (tip/next) ([@​Anasqx](https://github.com/Anasqx)) ##### :nail_care: Polish - `create-docusaurus` - [#​8712](https://github.com/facebook/docusaurus/pull/8712) polish(create-docusaurus): the starter template should use a navbar item "docSidebar" instead of "doc" (less fragile on updates) ([@​biplavmz](https://github.com/biplavmz)) - `docusaurus-theme-classic`, `docusaurus-theme-common`, `docusaurus-utils-common`, `docusaurus` - [#​8735](https://github.com/facebook/docusaurus/pull/8735) polish(theme): better error messages on navbar item rendering failures + ErrorCauseBoundary API ([@​tannerdolby](https://github.com/tannerdolby)) - `docusaurus-theme-classic`, `docusaurus-theme-common`, `docusaurus` - [#​8736](https://github.com/facebook/docusaurus/pull/8736) polish(core): better styling for error screens ([@​tannerdolby](https://github.com/tannerdolby)) ##### Committers: 14 - Anas ([@​Anasqx](https://github.com/Anasqx)) - Armano ([@​armano2](https://github.com/armano2)) - Davide Donadio ([@​ZarakiKanzaki](https://github.com/ZarakiKanzaki)) - Dewansh Thakur ([@​dewanshDT](https://github.com/dewanshDT)) - Joshua Chen ([@​Josh-Cena](https://github.com/Josh-Cena)) - Kagan ([@​kagankan](https://github.com/kagankan)) - Moritz Stückler ([@​pReya](https://github.com/pReya)) - Mysterious_Dev ([@​Mysterious-Dev](https://github.com/Mysterious-Dev)) - Petter Drønnen ([@​dr0nn1](https://github.com/dr0nn1)) - Sébastien Lorber ([@​slorber](https://github.com/slorber)) - Tanner Dolby ([@​tannerdolby](https://github.com/tannerdolby)) - TrueQAP ([@​trueqap](https://github.com/trueqap)) - Vishruta Patil ([@​Vishruta-Patil](https://github.com/Vishruta-Patil)) - [@​biplavmz](https://github.com/biplavmz) </details> <details> <summary>Microsoft/playwright</summary> ### [`v1.32.1`](https://github.com/microsoft/playwright/releases/tag/v1.32.1) [Compare Source](https://github.com/Microsoft/playwright/compare/v1.32.0...v1.32.1) #### Highlights [https://github.com/microsoft/playwright/issues/21832](https://github.com/microsoft/playwright/issues/21832) - \[BUG] Trace is not opening on specific broken locator[https://github.com/microsoft/playwright/issues/21897](https://github.com/microsoft/playwright/issues/21897)7 - \[BUG] --ui fails to open with error reading mainFrame from an undefined this.\_pa[https://github.com/microsoft/playwright/issues/21918](https://github.com/microsoft/playwright/issues/21918)918 - \[BUG]: UI mode, skipped tests not being fo[https://github.com/microsoft/playwright/issues/21941](https://github.com/microsoft/playwright/issues/21941)1941 - \[BUG] UI mode does not show webServer startup er[https://github.com/microsoft/playwright/issues/21953](https://github.com/microsoft/playwright/issues/21953)21953 - \[BUG] Parameterized tests are not displayed in the UI mode #### Browser Versions - Chromium 112.0.5615.29 - Mozilla Firefox 111.0 - WebKit 16.4 This version was also tested against the following stable channels: - Google Chrome 111 - Microsoft Edge 111 ### [`v1.32.0`](https://github.com/microsoft/playwright/releases/tag/v1.32.0) [Compare Source](https://github.com/Microsoft/playwright/compare/v1.31.2...v1.32.0) #### 📣 Introducing UI Mode (preview) <a href="https://www.youtube.com/watch?v=jF0yA-JLQW0"><img src="https://user-images.githubusercontent.com/746130/227044467-b4db82dc-c7fa-40d7-a0c8-8f702581c3b9.png" width=340></a> <a href="https://www.youtube.com/watch?v=jF0yA-JLQW0">Playwright v1.32 updates</a> New UI Mode lets you explore, run and debug tests. Comes with a built-in watch mode.  Engage with a new flag `--ui`: ```sh npx playwright test --ui ``` #### New APIs - New options `option: updateMode` and `option: updateContent` in [`page.routeFromHAR()`](https://playwright.dev/docs/api/class-page#page-route-from-har) and [`browserContext.routeFromHAR()`](https://playwright.dev/docs/api/class-browsercontext#browser-context-route-from-har). - Chaining existing locator objects, see [locator docs](https://playwright.dev/docs/locators#chaining-locators) for details. - New property [`TestInfo.testId`](https://playwright.dev/docs/api/class-testinfo#test-info-test-id). - New option `name` in method [`Tracing.startChunk()`](https://playwright.dev/docs/api/class-tracing#tracing-start-chunk). #### ⚠️ Breaking change in component tests Note: **component tests only**, does not affect end-to-end tests. - `@playwright/experimental-ct-react` now supports **React 18 only**. - If you're running component tests with React 16 or 17, please replace `@playwright/experimental-ct-react` with `@playwright/experimental-ct-react17`. #### Browser Versions - Chromium 112.0.5615.29 - Mozilla Firefox 111.0 - WebKit 16.4 This version was also tested against the following stable channels: - Google Chrome 111 - Microsoft Edge 111 </details> <details> <summary>sveltejs/kit</summary> ### [`v1.15.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#​1150) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@1.14.0...@sveltejs/kit@1.15.0) ##### Minor Changes - feat: expose stronger typed `SubmitFunction` through `./$types` ([#​9201](https://github.com/sveltejs/kit/pull/9201)) ##### Patch Changes - fix: throw error when file can't be found in Vite manifest ([#​9558](https://github.com/sveltejs/kit/pull/9558)) - fix: make `error.message` enumerable when sending `ssrLoadModule` error to client ([#​9440](https://github.com/sveltejs/kit/pull/9440)) - fix: pass `publicDir` Vite config in SSR ([#​9565](https://github.com/sveltejs/kit/pull/9565)) - fix: balance parentheses in error about wrong content type for action ([#​9513](https://github.com/sveltejs/kit/pull/9513)) ### [`v1.14.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#​1140) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@1.13.0...@sveltejs/kit@1.14.0) ##### Minor Changes - feat: add HMR to fallback error pages during dev ([#​9497](https://github.com/sveltejs/kit/pull/9497)) ##### Patch Changes - fix: add `submitter` type to `SumbitFunction` ([#​9484](https://github.com/sveltejs/kit/pull/9484)) ### [`v1.13.0`](https://github.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#​1130) [Compare Source](https://github.com/sveltejs/kit/compare/@sveltejs/kit@1.12.0...@sveltejs/kit@1.13.0) ##### Minor Changes - feat: add dark mode styles to default error page ([#​9460](https://github.com/sveltejs/kit/pull/9460)) ##### Patch Changes - fix: recover from errors during dev by reloading ([#​9441](https://github.com/sveltejs/kit/pull/9441)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27) [Compare Source](https://github.com/typescript-eslint/typescript-eslint/compare/v5.56.0...v5.57.0) ##### Bug Fixes - **eslint-plugin:** \[no-unnecessary-boolean-literal-compare] simplify fixer and add support for double negation ([#​6620](https://github.com/typescript-eslint/typescript-eslint/issues/6620)) ([81c8519](https://github.com/typescript-eslint/typescript-eslint/commit/81c85193d27d2e7f6d12bc259088b9b73dbe1e8b)) - **eslint-plugin:** correct crashes with getTypeArguments for ts < 3.7 ([#​6767](https://github.com/typescript-eslint/typescript-eslint/issues/6767)) ([59eab58](https://github.com/typescript-eslint/typescript-eslint/commit/59eab587890a915387444d00c4a9387aed602718)) ##### Features - **eslint-plugin:** \[consistent-type-assertions] add suggestions for objectLiteralTypeAssertions ([#​6642](https://github.com/typescript-eslint/typescript-eslint/issues/6642)) ([720e811](https://github.com/typescript-eslint/typescript-eslint/commit/720e81138b66c94c60c4a4471b86b7d8567b6df0)) - **eslint-plugin:** \[consistent-type-assertions] autofix angle bracket assertions to as ([#​6641](https://github.com/typescript-eslint/typescript-eslint/issues/6641)) ([ad8ea64](https://github.com/typescript-eslint/typescript-eslint/commit/ad8ea64dbdf06c92ff72b48022f041693a8d7076)) - **eslint-plugin:** add `no-duplicate-type-constituents` rule ([#​5728](https://github.com/typescript-eslint/typescript-eslint/issues/5728)) ([bc31078](https://github.com/typescript-eslint/typescript-eslint/commit/bc31078cf86d69eee881e4a7daeffa347c1d82a7)) ### [`v5.56.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#​5560-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5550v5560-2023-03-20) [Compare Source](https://github.com/typescript-eslint/typescript-eslint/compare/v5.55.0...v5.56.0) ##### Bug Fixes - **eslint-plugin:** \[member-ordering] check order when optionalityOrder is present with no optional members ([#​6619](https://github.com/typescript-eslint/typescript-eslint/issues/6619)) ([6aff431](https://github.com/typescript-eslint/typescript-eslint/commit/6aff431668eb0d25aa74b527cbe458f9dcd0d92a)) - **eslint-plugin:** \[no-misused-promises] avoid unnecessary calls to getContextualType ([#​6193](https://github.com/typescript-eslint/typescript-eslint/issues/6193)) ([745cfe4](https://github.com/typescript-eslint/typescript-eslint/commit/745cfe4a35319416b3c307ee9fd57c63bf1660cd)) - **eslint-plugin:** \[no-misused-promises] fix incorrect detection of void functions in JSX attributes ([#​6638](https://github.com/typescript-eslint/typescript-eslint/issues/6638)) ([9e41cee](https://github.com/typescript-eslint/typescript-eslint/commit/9e41ceeaea3bf266e5114cfb1855e70a1a13284b)) - **eslint-plugin:** \[strict-boolean-expression] support falsy and truthy literals simultaneously ([#​6672](https://github.com/typescript-eslint/typescript-eslint/issues/6672)) ([62ef487](https://github.com/typescript-eslint/typescript-eslint/commit/62ef487a99010827e99a792db5e565ad7c1d6220)) - **eslint-plugin:** \[strict-boolean-expressions] handle truthy enums ([#​6618](https://github.com/typescript-eslint/typescript-eslint/issues/6618)) ([0d0639f](https://github.com/typescript-eslint/typescript-eslint/commit/0d0639fb25e5ac8d7b5e4ceac4273e17e8ee0249)) - **eslint-plugin:** add TSPropertySignature with TSFunctionType annotation to typeMethod selector ([#​6645](https://github.com/typescript-eslint/typescript-eslint/issues/6645)) ([3fc5c63](https://github.com/typescript-eslint/typescript-eslint/commit/3fc5c63f87bfd9d95f7e51fddc7ef16a6c3c5662)) ##### Features - **eslint-plugin:** add allowNever support to restrict-template-expressions ([#​6554](https://github.com/typescript-eslint/typescript-eslint/issues/6554)) ([423f164](https://github.com/typescript-eslint/typescript-eslint/commit/423f1642424293488fa03a52777c0df73a40e5fd)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v5.57.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5570-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5560v5570-2023-03-27) [Compare Source](https://github.com/typescript-eslint/typescript-eslint/compare/v5.56.0...v5.57.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) ### [`v5.56.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#​5560-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5550v5560-2023-03-20) [Compare Source](https://github.com/typescript-eslint/typescript-eslint/compare/v5.55.0...v5.56.0) **Note:** Version bump only for package [@​typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> <details> <summary>actions/checkout</summary> ### [`v3.5.0`](https://github.com/actions/checkout/releases/tag/v3.5.0) [Compare Source](https://github.com/actions/checkout/compare/v3.4.0...v3.5.0) ##### What's Changed - Add new public key for known_hosts by [@​cdb](https://github.com/cdb) in [https://github.com/actions/checkout/pull/1237](https://github.com/actions/checkout/pull/1237) ##### New Contributors - [@​cdb](https://github.com/cdb) made their first contribution in [https://github.com/actions/checkout/pull/1237](https://github.com/actions/checkout/pull/1237) **Full Changelog**: https://github.com/actions/checkout/compare/v3.4.0...v3.5.0 </details> <details> <summary>anchore/sbom-action</summary> ### [`v0.13.4`](https://github.com/anchore/sbom-action/releases/tag/v0.13.4): v0.14.0 [Compare Source](https://github.com/anchore/sbom-action/compare/v0.13.3...v0.13.4) #### Changes in v0.13.4 - Added support of workflow artifact's retention policy ([#​398](https://github.com/anchore/sbom-action/issues/398)) \[[ViacheslavKudinov](https://github.com/ViacheslavKudinov)] - Use the correct SHA for dependency snapshots from pull requests ([#​401](https://github.com/anchore/sbom-action/issues/401)) \[[juxtin](https://github.com/juxtin)] - Update Syft to v0.75.0 ([#​394](https://github.com/anchore/sbom-action/issues/394)) \[[anchore-actions-token-generator](https://github.com/anchore-actions-token-generator)] </details> <details> <summary>eslint/eslint</summary> ### [`v8.37.0`](https://github.com/eslint/eslint/releases/tag/v8.37.0) [Compare Source](https://github.com/eslint/eslint/compare/v8.36.0...v8.37.0) #### Features - [`b6ab8b2`](https://github.com/eslint/eslint/commit/b6ab8b2a2ca8807baca121407f5bfb0a0a839427) feat: `require-unicode-regexp` add suggestions ([#​17007](https://github.com/eslint/eslint/issues/17007)) (Josh Goldberg) - [`10022b1`](https://github.com/eslint/eslint/commit/10022b1f4bda1ad89193512ecf18c2ee61db8202) feat: Copy getScope() to SourceCode ([#​17004](https://github.com/eslint/eslint/issues/17004)) (Nicholas C. Zakas) - [`1665c02`](https://github.com/eslint/eslint/commit/1665c029acb92bf8812267f1647ad1a7054cbcb4) feat: Use plugin metadata for flat config serialization ([#​16992](https://github.com/eslint/eslint/issues/16992)) (Nicholas C. Zakas) - [`b3634f6`](https://github.com/eslint/eslint/commit/b3634f695ddab6a82c0a9b1d8695e62b60d23366) feat: docs license ([#​17010](https://github.com/eslint/eslint/issues/17010)) (Samuel Roldan) - [`892e6e5`](https://github.com/eslint/eslint/commit/892e6e58c5a07a549d3104de3b6b5879797dc97f) feat: languageOptions.parser must be an object. ([#​16985](https://github.com/eslint/eslint/issues/16985)) (Nicholas C. Zakas) #### Bug Fixes - [`619f3fd`](https://github.com/eslint/eslint/commit/619f3fd17324c7b71bf17e02047d0c6dc7e5109e) fix: correctly handle `null` default config in `RuleTester` ([#​17023](https://github.com/eslint/eslint/issues/17023)) (Brad Zacher) - [`1fbf118`](https://github.com/eslint/eslint/commit/1fbf1184fed57df02640aad4659afb54dc26a2e9) fix: `getFirstToken`/`getLastToken` on comment-only node ([#​16889](https://github.com/eslint/eslint/issues/16889)) (Francesco Trotta) - [`129e252`](https://github.com/eslint/eslint/commit/129e252132c7c476d7de17f40b54a333ddb2e6bb) fix: Fix typo in `logical-assignment-operators` rule description ([#​17000](https://github.com/eslint/eslint/issues/17000)) (Francesco Trotta) #### Documentation - [`75339df`](https://github.com/eslint/eslint/commit/75339df99418df4d7e05a77e42ed7e22eabcc9e0) docs: fix typos and missing info in id-match docs ([#​17029](https://github.com/eslint/eslint/issues/17029)) (Ed Lucas) - [`ec2d830`](https://github.com/eslint/eslint/commit/ec2d8307850dd039e118c001416606e1e0342bc8) docs: Fix typos in the `semi` rule docs ([#​17012](https://github.com/eslint/eslint/issues/17012)) (Andrii Lundiak) - [`e39f28d`](https://github.com/eslint/eslint/commit/e39f28d8578a00f4da8d4ddad559547950128a0d) docs: add back to top button ([#​16979](https://github.com/eslint/eslint/issues/16979)) (Tanuj Kanti) - [`721c717`](https://github.com/eslint/eslint/commit/721c71782a7c11025689a1500e7690fb3794fcce) docs: Custom Processors cleanup and expansion ([#​16838](https://github.com/eslint/eslint/issues/16838)) (Ben Perlmutter) - [`d049f97`](https://github.com/eslint/eslint/commit/d049f974103e530ef76ede25af701635caf1f405) docs: 'How ESLint is Maintained' page ([#​16961](https://github.com/eslint/eslint/issues/16961)) (Ben Perlmutter) - [`5251a92`](https://github.com/eslint/eslint/commit/5251a921866e8d3b380dfe8db8a6e6ab97773d5e) docs: Describe guard options for guard-for-in ([#​16986](https://github.com/eslint/eslint/issues/16986)) (alope107) - [`6157d81`](https://github.com/eslint/eslint/commit/6157d813e19b80481a46f8cbdf9eae18a55e5619) docs: Add example to guard-for-in docs. ([#​16983](https://github.com/eslint/eslint/issues/16983)) (alope107) - [`fd47998`](https://github.com/eslint/eslint/commit/fd47998af6efadcdf5ba93e0bd1f4c02d97d22b3) docs: update `Array.prototype.toSorted` specification link ([#​16982](https://github.com/eslint/eslint/issues/16982)) (Milos Djermanovic) - [`3e1cf6b`](https://github.com/eslint/eslint/commit/3e1cf6bfc5ebc29314ddbe462d6cb580e9ab085c) docs: Copy edits on Maintain ESLint docs ([#​16939](https://github.com/eslint/eslint/issues/16939)) (Ben Perlmutter) #### Chores - [`c67f299`](https://github.com/eslint/eslint/commit/c67f2992a743de4765bb6f11c12622e3651324b9) chore: upgrade [@​eslint/js](https://github.com/eslint/js)[@​8](https://github.com/8).37.0 ([#​17033](https://github.com/eslint/eslint/issues/17033)) (Milos Djermanovic) - [`ee9ddbd`](https://github.com/eslint/eslint/commit/ee9ddbd63e262aed0052853760866c7a054af561) chore: package.json update for [@​eslint/js](https://github.com/eslint/js) release (ESLint Jenkins) - [`dddb475`](https://github.com/eslint/eslint/commit/dddb47528816cd7e2e737bfde108ed4d62e6a219) chore: upgrade [@​eslint/eslintrc](https://github.com/eslint/eslintrc)[@​2](https://github.com/2).0.2 ([#​17032](https://github.com/eslint/eslint/issues/17032)) (Milos Djermanovic) - [`522431e`](https://github.com/eslint/eslint/commit/522431e5206bac2fcb41c0d6dc98a84929203bee) chore: upgrade espree@9.5.1 ([#​17031](https://github.com/eslint/eslint/issues/17031)) (Milos Djermanovic) - [`f5f9a88`](https://github.com/eslint/eslint/commit/f5f9a88c79b32222c0331a9bac1c02571d953b69) chore: upgrade eslint-visitor-keys@3.4.0 ([#​17030](https://github.com/eslint/eslint/issues/17030)) (Milos Djermanovic) - [`4dd8d52`](https://github.com/eslint/eslint/commit/4dd8d524e0fc9e8e2019df13f8b968021600e85c) ci: bump actions/stale from 7 to 8 ([#​17026](https://github.com/eslint/eslint/issues/17026)) (dependabot\[bot]) - [`ad9dd6a`](https://github.com/eslint/eslint/commit/ad9dd6a933fd098a0d99c6a9aa059850535c23ee) chore: remove duplicate scss, ([#​17005](https://github.com/eslint/eslint/issues/17005)) (Strek) - [`ada6a3e`](https://github.com/eslint/eslint/commit/ada6a3e6e3607523958f35e1260537630ec0e976) ci: unpin Node 19 ([#​16993](https://github.com/eslint/eslint/issues/16993)) (Milos Djermanovic) - [`c3da975`](https://github.com/eslint/eslint/commit/c3da975e69fde46f35338ce48528841a8dc1ffd2) chore: Remove triage label from template ([#​16990](https://github.com/eslint/eslint/issues/16990)) (Nicholas C. Zakas) - [`69bc0e2`](https://github.com/eslint/eslint/commit/69bc0e2f4412998f9384600a100d7882ea4dd3f3) ci: pin Node 19 to 19.7.0 ([#​16987](https://github.com/eslint/eslint/issues/16987)) (Milos Djermanovic) </details> <details> <summary>prettier/eslint-config-prettier</summary> ### [`v8.8.0`](https://github.com/prettier/eslint-config-prettier/blob/HEAD/CHANGELOG.md#Version-880-2023-03-20) [Compare Source](https://github.com/prettier/eslint-config-prettier/compare/v8.7.0...v8.8.0) - Added: \[[@​typescript-eslint/lines-around-comment](https://github.com/typescript-eslint/lines-around-comment)]. Thanks to [@​ttionya](https://github.com/ttionya)! </details> <details> <summary>defenseunicorns/syft</summary> ### [`v0.75.0`](https://github.com/defenseunicorns/syft/compare/v0.75.0-DU...v0.75.0) [Compare Source](https://github.com/defenseunicorns/syft/compare/v0.75.0-DU...v0.75.0) </details> <details> <summary>docker/cli</summary> ### [`v23.0.2+incompatible`](https://github.com/docker/cli/compare/v23.0.1...v23.0.2) [Compare Source](https://github.com/docker/cli/compare/v23.0.1...v23.0.2) </details> <details> <summary>fluxcd/helm-controller</summary> ### [`v0.31.2`](https://github.com/fluxcd/helm-controller/releases/tag/v0.31.2) [Compare Source](https://github.com/fluxcd/helm-controller/compare/v0.31.1...v0.31.2) [CHANGELOG](https://github.com/fluxcd/helm-controller/blob/main/CHANGELOG.md) </details> <details> <summary>fluxcd/source-controller</summary> ### [`v0.36.1`](https://github.com/fluxcd/source-controller/releases/tag/v0.36.1) [Compare Source](https://github.com/fluxcd/source-controller/compare/v0.36.0...v0.36.1) [CHANGELOG](https://github.com/fluxcd/source-controller/blob/main/CHANGELOG.md) </details> <details> <summary>go-logr/logr</summary> ### [`v1.2.4`](https://github.com/go-logr/logr/releases/tag/v1.2.4) [Compare Source](https://github.com/go-logr/logr/compare/v1.2.3...v1.2.4) This is a collection of small bugfixes and documentation updates. #### What's Changed - Fix syntax in documentation by [@​balki](https://github.com/balki) in [https://github.com/go-logr/logr/pull/144](https://github.com/go-logr/logr/pull/144) - testr: use an interface to make it work with \*testing.B and \*testing.F by [@​jeandeaual](https://github.com/jeandeaual) in [https://github.com/go-logr/logr/pull/143](https://github.com/go-logr/logr/pull/143) - If logging as JSON and the type is json.RawMessage log it "as-is" by [@​sfc-gh-jchacon](https://github.com/sfc-gh-jchacon) in [https://github.com/go-logr/logr/pull/147](https://github.com/go-logr/logr/pull/147) - Make zero value useful & add .IsZero() by [@​wojas](https://github.com/wojas) in [https://github.com/go-logr/logr/pull/153](https://github.com/go-logr/logr/pull/153) - testr: merge testLogger and testLoggerInterface by [@​thockin](https://github.com/thockin) in [https://github.com/go-logr/logr/pull/160](https://github.com/go-logr/logr/pull/160) - funcr: JSON invalid output with 1st field omitted by [@​thockin](https://github.com/thockin) in [https://github.com/go-logr/logr/pull/159](https://github.com/go-logr/logr/pull/159) - Make github assign PRs and issues by [@​thockin](https://github.com/thockin) in [https://github.com/go-logr/logr/pull/162](https://github.com/go-logr/logr/pull/162) - Fix comments on optional sink interfaces by [@​thockin](https://github.com/thockin) in [https://github.com/go-logr/logr/pull/161](https://github.com/go-logr/logr/pull/161) - Add examples for Logger methods by [@​thockin](https://github.com/thockin) in [https://github.com/go-logr/logr/pull/163](https://github.com/go-logr/logr/pull/163) - funcr: optimize WithValues/WithName/WithCallDepth by [@​pohly](https://github.com/pohly) in [https://github.com/go-logr/logr/pull/165](https://github.com/go-logr/logr/pull/165) - make Discard logger equal to null logger by [@​pohly](https://github.com/pohly) in [https://github.com/go-logr/logr/pull/166](https://github.com/go-logr/logr/pull/166) #### New Contributors - [@​balki](https://github.com/balki) made their first contribution in [https://github.com/go-logr/logr/pull/144](https://github.com/go-logr/logr/pull/144) - [@​jeandeaual](https://github.com/jeandeaual) made their first contribution in [https://github.com/go-logr/logr/pull/143](https://github.com/go-logr/logr/pull/143) - [@​sfc-gh-jchacon](https://github.com/sfc-gh-jchacon) made their first contribution in [https://github.com/go-logr/logr/pull/147](https://github.com/go-logr/logr/pull/147) **Full Changelog**: https://github.com/go-logr/logr/compare/v1.2.3...v1.2.4 </details> <details> <summary>goccy/go-yaml</summary> ### [`v1.10.1`](https://github.com/goccy/go-yaml/releases/tag/v1.10.1): 1.10.1 [Compare Source](https://github.com/goccy/go-yaml/compare/v1.10.0...v1.10.1) #### What's Changed - Quote YAML 1.1 bools at encoding time for compatibility with other legacy parsers by [@​mumoshu](https://github.com/mumoshu) in [https://github.com/goccy/go-yaml/pull/354](https://github.com/goccy/go-yaml/pull/354) - Update CI by [@​goccy](https://github.com/goccy) in [https://github.com/goccy/go-yaml/pull/364](https://github.com/goccy/go-yaml/pull/364) - Update Go Version by [@​goccy](https://github.com/goccy) in [https://github.com/goccy/go-yaml/pull/365](https://github.com/goccy/go-yaml/pull/365) - Don't trim all space characters in SequenceNode.blockStyleString by [@​martin-sucha](https://github.com/martin-sucha) in [https://github.com/goccy/go-yaml/pull/361](https://github.com/goccy/go-yaml/pull/361) - Add support of 32-bit architecture by [@​ozraru](https://github.com/ozraru) in [https://github.com/goccy/go-yaml/pull/350](https://github.com/goccy/go-yaml/pull/350) - Support strings starting with @​ by [@​10io](https://github.com/10io) in [https://github.com/goccy/go-yaml/pull/339](https://github.com/goccy/go-yaml/pull/339) #### New Contributors - [@​mumoshu](https://github.com/mumoshu) made their first contribution in [https://github.com/goccy/go-yaml/pull/354](https://github.com/goccy/go-yaml/pull/354) - [@​ozraru](https://github.com/ozraru) made their first contribution in [https://github.com/goccy/go-yaml/pull/350](https://github.com/goccy/go-yaml/pull/350) - [@​10io](https://github.com/10io) made their first contribution in [https://github.com/goccy/go-yaml/pull/339](https://github.com/goccy/go-yaml/pull/339) **Full Changelog**: https://github.com/goccy/go-yaml/compare/v1.10.0...v1.10.1 </details> <details> <summary>moby/moby</summary> ### [`v23.0.2+incompatible`](https://github.com/moby/moby/compare/v23.0.1...v23.0.2) [Compare Source](https://github.com/moby/moby/compare/v23.0.1...v23.0.2) </details> <details> <summary>pterm/pterm</summary> ### [`v0.12.57`](https://github.com/pterm/pterm/blob/HEAD/CHANGELOG.md#v01257---2023-03-28) [Compare Source](https://github.com/pterm/pterm/compare/v0.12.56...v0.12.57) ##### Code Refactoring - use `pterm.Print` instead of `fmt.Print` functions </details> <details> <sum </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/defenseunicorns/zarf). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNy4xIiwidXBkYXRlZEluVmVyIjoiMzUuMjMuMyJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <me@racer159.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #356. The code would have removed more spaces than it added.
A better solution long-term would probably be to add a specialized method to StringNode to not add the prefix in the first place.