Quote the numbers even if they are out of range

[shuheiktgw]

Closes #586

The IsNeedQuoted function previously returned false when a given string was out of range, as ToNumber failed to parse such strings. I updated the IsNeedQuoted function to check the error returned by ToNumber and, if it is strconv.ErrRange, ensure the string is quoted instead.

Before submitting your PR, please confirm the following.

• Describe the purpose for which you created this PR.
• Create test code that corresponds to the modification

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.47%. Comparing base (e1d8782) to head (3e2fe49).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
+ Coverage   77.43%   77.47%   +0.04%     
==========================================
  Files          21       21              
  Lines        7772     7787      +15     
==========================================
+ Hits         6018     6033      +15     
  Misses       1342     1342              
  Partials      412      412              

[ccoVeille]

This looks odd

Shouldn't it be better and more logic now you refactored to have something like that

Suggested change

	if num, _ := token.ToNumber(tk.Value); num != nil {
	if num, err := token.ToNumber(tk.Value); err == nil {

With code refactored to return an error when

[ccoVeille]

This is enough

Suggested change

	if err != nil {
	// Need quotes even when the value is out of range
	var numErr *strconv.NumError
	if errors.As(err, &numErr) && errors.Is(numErr.Err, strconv.ErrRange) {
	return true
	}
	}
	// Need quotes even when the value is out of range
	var numErr *strconv.NumError
	if errors.As(err, &numErr) && errors.Is(numErr.Err, strconv.ErrRange) {
	return true
	}

[ccoVeille]

This change looks like a hammer to fix a scratch.

You are updating the signature of an exported method, it would have consequence.

I would have checked the ErrRange error in this method, and set a boolean variable NeedQuote on the NumberValue struct, then use it in IsQuoteNeeded

[shuheiktgw]

Thank you for your comments, @ccoVeille! Hmm, you are right. I haven't thought about the possibility that people use the method, but let me think about it a little more carefully 👍

[shuheiktgw]

I’ve migrated most of the logic from ToNumber to a new function called toNumber, preserved the original interface of ToNumber, and created a new function called isNumber to check if a given string is a number 🙂

[ccoVeille]

Thanks