Don't decompress gzip if data doesn't look like gzip #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WGH-
force-pushed
the
gzip-probing
branch
2 times, most recently
from
a6fee18
to
50c9eeb
Compare
This is not about Content-Encoding: gzip, which is undone automatically by Go net/http. This is about files that are compressed as is, e.g. /sitemap.xml.gz, without Content-Encoding: gzip being sent.
|
@asciimoo ping |
Prevents incorrect response being returned in cases like /sitemap.xml.gz is requested, but uncompressed 404 page is served instead. Thanks-to: Seth Davis <seth@xyplanningnetwork.com>
|
@seedifferently I added a different test-case compared to what you did in #792, but it should catch the same problem nonetheless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #745 for more information.
Closes #745