Fix attempt to read gzip content from responses that cannot contain content #792
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colly currently returns an
EOF
error on responses that contain aContent-Encoding: gzip
header, but no body content.This happens due to the initialization of the gzip reader here attempting to parse gzip header data from the response body, even though the body is empty.
RFC 9110 section 15 states that 1xx, 204, and 304 responses cannot contain content. However, some servers will still send a
Content-Encoding
header.This is my best guess at how to instruct colly not to reach for the gzip reader in these scenarios (the non-gzip reader gracefully handles empty bodies).