Implement content sniffing for HTML parsing #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welp, |
Instead of looking for "html" substring, actually parse the MIME type string. Don't use mime.ParseMediaType though as it doesn't handle invalid duplicate parameters (e.g. "text/html; charset=UTF-8; charset=utf-8") that occur in the wild.
Web pages can be served without Content-Type set, in which case browsers employ content sniffing. Do the same here, in Colly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web pages can be served without
Content-Typeset, in which case browsers employ content sniffing. Do the same here, in Colly.While we're at it, change the Content-Type check to something stricter than mere "html" substring match.