You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
At this point, all tartufo config has been moved into the one central configuration file, except for --rules. In order to keep everything consistent, we should fix this one last one.
Describe the solution you'd like
Use of the --rules option should present the user with a DeprecationWarning
New regex patterns should instead be specified in the configuration file as a table of tables, similar to new style entropy exclusion. It would probably look something like
Feature Request
Is your feature request related to a problem? Please describe.
At this point, all tartufo config has been moved into the one central configuration file, except for
--rules
. In order to keep everything consistent, we should fix this one last one.Describe the solution you'd like
Use of the
--rules
option should present the user with aDeprecationWarning
New regex patterns should instead be specified in the configuration file as a table of tables, similar to new style entropy exclusion. It would probably look something like
OR
Required keys would be "name" and "pattern"; "path_pattern" would be optional.
As far as the future deprecation path, I see two possibilities:
main
directly, then ported to thev3.x
branch, with the--rules
option removed entirely in v3.0v3.x
, and we decide upon some far future version (likely even v4.0) where the--rules
option can be fully removedThe choice is up to the author of the PR!
The text was updated successfully, but these errors were encountered: