Deprecate --rules in favor of rule-patterns #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjustments to make mypy and pytest happy.
There's really no reason for it to be a dict. This change makes it more consistent with similar inputs and simplifies some corner cases. Note the uniqueness test now is based on the actual pattern rather than the name (reason), and we no longer warn about duplicates because you can't overwrite a rule with one that does something different.
|
There was no good place to document a new configuration option like this, so I added it to the end of the |
tarkatronic
requested review from
jmink-godaddy,
rscottbailey,
mayuriesha and
sushantmimani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
Fixes #256
What's new?
rule-patternsconfiguration option has been added to move the contents of rules files directly into the tartufo config file.--rulesoption will now raise aDeprecationWarning.