Switch to Pygit2 #233
Merged
Switch to Pygit2 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looking pretty good, although I bet it was a lot harder to come up with the changes than it was to read them. I noted one point where a message was dropped in the transformation -- I'm guessing that is unintentional because the look-and-feel appears unchanged everywhere else.
emayuri-godaddy
force-pushed
the
pygit2
branch
from
2d4719b
to
2d01fae
Compare
sushantmimani
force-pushed
the
pygit2
branch
2 times, most recently
from
963cea2
to
0cefabe
Compare
sushantmimani
requested review from
djlarsu,
jmink-godaddy,
sjacoby-godaddy and
tarkatronic
and removed request for
a team
rbailey-godaddy
approved these changes
Oct 26, 2021
tarkatronic
suggested changes
Oct 26, 2021
Closed
tarkatronic
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
This will be a great starting point for a fast new tartufo! Thanks for all the work @jgowdy, @sushantmimani, and @emayuri-godaddy!
Roll pygit2 back to 1.6.x for Py3.6 compatibility
Fix failing test
15 tasks
This was referenced Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
In its current version, this PR will flag findings for renamed files even if the findings in the new file(after rename) have been excluded from Tartufo.
What's new?
This is the first PR in a series of PRs aimed at re-implementing #122. Current status:
--max-depthoption is unimplemented