Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for v2.10.0 #263

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Conversation

mayuriesha
Copy link
Contributor

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

What's new?

CHANGELOG.md Outdated
Comment on lines 7 to 12
v2.2.0 through v2.9.0 inclusive mishandle `scan-remote-repo`. Only the repository's
default branch was scanned, and secrets present in other branches would not be
discovered. Additionally, the `--branch branch-name` option did not operate correctly
for remote repositories. Some versions would scan nothing and report no errors, and
other versions aborted immediately, claiming the branch did not exist (even if it did).
v2.10.0 corrects these problems and may detect secrets that were not reported by previous versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it will have an impact on the Markdown formatting, but these lines should be indented by 2 spaces, to keep them aligned with their bullet point. At least, that is our convention. 😄

Copy link
Contributor

@tarkatronic tarkatronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @mayuriesha!

Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅

@mayuriesha mayuriesha merged commit 77ca193 into godaddy:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants