Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --entropy-sensitivity option for controlling entropy checks #272

Merged
merged 12 commits into from
Nov 15, 2021

Commits on Nov 12, 2021

  1. Add --sensitivity option

    Fixes #265
    
    Provide more comprehensible alternative for tuning entropy checking.
    This is applied consistently across all target character sets, and stated
    in a way that is slightly easier to understand ("higher means more
    likely to flag a given string").
    
    The older `--b64-entropy-score` and `--hex-entropy-score` options are
    marked as deprecated but retained for backwards compatibility (and they
    override `--sensitivity` if used together with it).
    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    700af2d View commit details
    Browse the repository at this point in the history
  2. Change option name

    Use `--entropy-sensitivity` instead of `--sensitivity`
    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    7f2480f View commit details
    Browse the repository at this point in the history
  3. Wordsmithing

    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    23c0552 View commit details
    Browse the repository at this point in the history
  4. Wordsmithing again

    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    1a5daa4 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    799af80 View commit details
    Browse the repository at this point in the history
  6. linter fixups

    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b19a1b4 View commit details
    Browse the repository at this point in the history
  7. Documentation fixups

    ...in response to review comments
    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    54f5c9c View commit details
    Browse the repository at this point in the history
  8. Expose magic numbers as properties

    ...and use them instead of private members
    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    7cad444 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a1006bc View commit details
    Browse the repository at this point in the history
  10. Remove entropy scoring members

    Do everything from scratch instead of storing explicitly. This is a PITA
    because you can't combine `@property` and `@lru_cache()` and skipping
    the caching would be a killer.
    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    017f43b View commit details
    Browse the repository at this point in the history
  11. Review feedback tuneups

    * Consolidate common code for entropy limit back into a single method,
      and rework properties related to it so they are cleaner.
    * Invert sensitivity scale; adjust math and doc to match. It's still
      weird but aligns more closely to the underlying entropy metric.
    rscottbailey committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    b8f3a5a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Fix change log

    rscottbailey committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    b8264ed View commit details
    Browse the repository at this point in the history