Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing depricated flags --include-paths and --exclude-paths #276

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

mayuriesha
Copy link
Contributor

@mayuriesha mayuriesha commented Nov 9, 2021

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

closes #255

What's new?

  • Removed flags -i/--include-paths and -x/--exclude-paths which were deprecated since the release of tartufo v2.5.0

Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅

@sushantmimani
Copy link
Contributor

@mayuriesha There are merge conflicts that need to be fixed for this PR, before merge.

@mayuriesha mayuriesha merged commit c15330a into godaddy:v3.x Nov 10, 2021
@tarkatronic tarkatronic linked an issue Nov 10, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove --include-paths and --exclude-paths in v3.0
4 participants