Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs #288

Merged
merged 20 commits into from
Jan 5, 2022
Merged

Updated docs #288

merged 20 commits into from
Jan 5, 2022

Conversation

tarkatronic
Copy link
Contributor

This is the beginning of a rework of the documentation for tartufo. It has had many issues for some time now, so I am taking this opportunity to incorporate user feedback and improve the overall structure and content of the documentation.

I am starting this as a draft, to give people a sense of where I am headed. The first swing I am taking is at making the documentation more complete. Next I will work on improving the overall structure, so that we don't have a confusing mess of "Usage" vs "Features" vs "Configuration" (that barely even talks about configuration). And then finally, adding an upgrade guide from v2 -> v3.

@tarkatronic tarkatronic added this to the Version 3.0 milestone Nov 30, 2021
@tarkatronic tarkatronic linked an issue Dec 1, 2021 that may be closed by this pull request
@tarkatronic tarkatronic changed the base branch from v3.x to main December 9, 2021 19:34
@sushantmimani sushantmimani marked this pull request as ready for review January 4, 2022 22:11
@sushantmimani sushantmimani requested a review from a team as a code owner January 4, 2022 22:11
@rbailey-godaddy rbailey-godaddy changed the title WIP: Updated docs ASEC-1660 Updated docs Jan 5, 2022
Copy link
Contributor

@rbailey-godaddy rbailey-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits. Also, asking again more concretely -- should I add commits for the v2-to-v3 upgrade documentation to this PR, or start a new one after this is merged?

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/source/configuration.rst Outdated Show resolved Hide resolved
rscottbailey and others added 5 commits January 5, 2022 14:17
This basically expands the CHANGELOG content from 3.x into a few sets of

* What will I see different?
* What do I do about it?

topics that should get users over the 2-to-3 hump even if they read
nothing else.
Co-authored-by: Scott Bailey <72747501+rbailey-godaddy@users.noreply.github.com>
Copy link
Contributor

@rbailey-godaddy rbailey-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course I think everything I wrote is fabulous. ;-) Everything else LGTM too...

@sushantmimani sushantmimani changed the title ASEC-1660 Updated docs Updated docs Jan 5, 2022
@sushantmimani
Copy link
Contributor

Of course I think everything I wrote is fabulous. ;-) Everything else LGTM too...

Ditto!

Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦅

@rbailey-godaddy rbailey-godaddy merged commit 6424683 into main Jan 5, 2022
@rbailey-godaddy rbailey-godaddy deleted the updated-docs branch January 5, 2022 22:09
@rbailey-godaddy
Copy link
Contributor

Fixes #279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of command-line options is far too brief
4 participants