Updating --include-path-patterns and --exclude-path-patterns to use a table of tables #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayuriesha
requested review from
tarkatronic,
sushantmimani and
rbailey-godaddy
tarkatronic
suggested changes
Dec 3, 2021
| ) | ||
| self.global_options.exclude_path_patterns = ("bar/",) |
There was a problem hiding this comment.
Same comment as the test above.
rbailey-godaddy
requested changes
Dec 7, 2021
|
@rbailey-godaddy I have created an issue to address the last few review comments as part of another PR after 3.0 is released |
rbailey-godaddy
approved these changes
Dec 7, 2021
Clean up `included_paths` and `excluded_paths` with basically the same logic used for godaddy#290.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
closes #257
What's new?
--include-path-patternsand--exclude-path-patternswith an option to specify the reason.Ex: include-path-patterns = [{path-pattern="path-pattern", reason="reason to include path patterns"}]