Fix #245: Better boolean flag help output #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarkatronic
requested review from
janerikcarlsen,
rfox-godaddy and
sjacoby-godaddy
tests/test_cli.py
Outdated
| @@ -103,9 +103,11 @@ def test_output_dir_is_called_out( | |||
| result = runner.invoke( | |||
| cli.main, ["--output-dir", "./foo", "scan-local-repo", "."] | |||
| ) | |||
| # Perform a little bit of trickery to make absolutely certain we get a full absolute path | |||
There was a problem hiding this comment.
May be a good idea to link the source of inspiration for this bit of trickery?
This was referenced Dec 8, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
Fixes #245
What's new?
Using the latest version of
clickgives us better output for our command line boolean flags. For example:becomes:
Turns out, there's also a whole ton of other bugfixes and improvements. One of those bugfixes related to path resolution in Windows and resulted in us needing to update some tests. Overall, should be a major positive!