Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tartufo exclusion for rule_pattern_config.toml #320

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Add tartufo exclusion for rule_pattern_config.toml #320

merged 1 commit into from
Jan 12, 2022

Conversation

sushantmimani
Copy link
Contributor

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

What's new?

  • Add tartufo exclusion for rule_pattern_config.toml. This file is used only in tests.

@sushantmimani sushantmimani requested a review from a team as a code owner January 12, 2022 21:17
@sushantmimani sushantmimani marked this pull request as draft January 12, 2022 21:23
@sushantmimani sushantmimani marked this pull request as ready for review January 12, 2022 21:23
mayuriesha
mayuriesha approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@mayuriesha mayuriesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sushantmimani sushantmimani merged commit 0fd8208 into godaddy:main Jan 12, 2022
@sushantmimani sushantmimani deleted the update-signature-exclusion branch January 12, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbailey-godaddy rbailey-godaddy rbailey-godaddy approved these changes

@mayuriesha mayuriesha mayuriesha approved these changes

@janerikcarlsen janerikcarlsen Awaiting requested review from janerikcarlsen janerikcarlsen is a code owner automatically assigned from godaddy/tartufo

@rfox-godaddy rfox-godaddy Awaiting requested review from rfox-godaddy rfox-godaddy is a code owner automatically assigned from godaddy/tartufo

@emayuri-godaddy emayuri-godaddy Awaiting requested review from emayuri-godaddy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sushantmimani @rbailey-godaddy @mayuriesha