Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: diff only if not already searched #420

Merged
merged 2 commits into from
Jan 4, 2023
Merged

fix: diff only if not already searched #420

merged 2 commits into from
Jan 4, 2023

Conversation

dclayton-godaddy
Copy link
Contributor

@dclayton-godaddy dclayton-godaddy commented Jan 3, 2023 •
edited
Loading

To help us get this pull request reviewed and merged quickly, please be sure to include the following items:

  • Tests (if applicable)
  • Documentation (if applicable)
  • Changelog entry
  • A full explanation here in the PR description of the work done

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Backward Compatibility

Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?

  • Yes (backward compatible)
  • No (breaking changes)

Issue Linking

What's new?

  • Invoke diff call only if diff hash was not already searched. This is a massive performance improvement.

@dclayton-godaddy dclayton-godaddy marked this pull request as ready for review January 4, 2023 18:25
@dclayton-godaddy dclayton-godaddy requested a review from a team as a code owner January 4, 2023 18:25
rbailey-godaddy
rbailey-godaddy approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@rbailey-godaddy rbailey-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

sushantmimani
sushantmimani approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@sushantmimani sushantmimani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sushantmimani sushantmimani merged commit 22ebf02 into godaddy:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushantmimani sushantmimani sushantmimani approved these changes

@rbailey-godaddy rbailey-godaddy rbailey-godaddy approved these changes

@emayuri-godaddy emayuri-godaddy Awaiting requested review from emayuri-godaddy emayuri-godaddy is a code owner automatically assigned from godaddy/tartufo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dclayton-godaddy @sushantmimani @rbailey-godaddy