-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Update #449
Merged
Merged
Documentation Update #449
Commits on Feb 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9b1bdf3 - Browse repository at this point
Copy the full SHA 9b1bdf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e46de9 - Browse repository at this point
Copy the full SHA 8e46de9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00c8e97 - Browse repository at this point
Copy the full SHA 00c8e97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 740efe5 - Browse repository at this point
Copy the full SHA 740efe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83f90b0 - Browse repository at this point
Copy the full SHA 83f90b0View commit details
Commits on Mar 1, 2023
-
This is really messed up, but seems to work reliably now with local invocations of `poetry run tox -e docs` where before it mostly failed. As usual, I don't understand the situations under where it was able to work before. We'll see if the CI tests actually succeed once I push this... * `Makefile` fixes Extensive debugging suggested two related failure modes, where the `sphinx-build` script could not be located or when executed it failed to load modules. Investigation revealed that the "here" lines at the top of `sphinx-build` and friends used relative paths (`#!.tox/docs/bin/python`), and it appeared this was invoked in contexts where this path was not resolvable. Tracing the actual chain of control from `poetry` to `tox` back to `poetry` to `make` makes it difficult to understand what is actually going on. In any event, the fix incorporated here works around the problem by locating the absolute location of `sphinx-build` and then invoking it using `python /real/location/of/sphinx-build`, which causes the problematic relative reference to be ignored because the python interpreter is located using the scoping rules provided by `poetry`. I believe this was the critical fix of everything incorporated here. * `pyproject.toml` editorial fixes These are nits, cleaning up spacing and unnecessary quoting, and have no functional impact. * `tox.ini` fixes This probably isn't important, but I noted `make` wasn't getting invoked via `poetry run` like everything else, so I fixed it.
Configuration menu - View commit details
-
Copy full SHA for 79769c4 - Browse repository at this point
Copy the full SHA 79769c4View commit details -
Use explicit dict instead of casting literal input
Configuration menu - View commit details
-
Copy full SHA for b5a1a94 - Browse repository at this point
Copy the full SHA b5a1a94View commit details -
Revert "Remove cache. Maybe it is causing version conflict."
This reverts commit 740efe5. The cache does not appear to be at fault; let's turn it back on.
Configuration menu - View commit details
-
Copy full SHA for fd3299d - Browse repository at this point
Copy the full SHA fd3299dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.