Support setting profiles-dir #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCZuurmond
requested changes
Feb 26, 2023
There was a problem hiding this comment.
@ConstantinoSchillebeeckx: Thank you for your PR, it looks very well done! I added some minor changes. Though, the CI is causing some problems:
- Could you rebase your branch on the main branch after fetching the changes? The isort pre-commit plugin caused problems, which are solved in the latest release.
- It looks like dbt requires a
profileattribute to be set on theArgs. This looks like a change done by dbt unrelated to your PR. However, since you are working on adding the profiles directory as a flag, maybe you could solve this in this PR?
|
@ConstantinoSchillebeeckx : I updated the testing matrix. It shows that the set-up fails since dbt 1.4. |
|
@JCZuurmond could you kick CI off again please? |
JCZuurmond
requested changes
Feb 28, 2023
JCZuurmond
approved these changes
Mar 1, 2023
There was a problem hiding this comment.
@ConstantinoSchillebeeckx : LGTM! Thanks for your contribution. Will you merge the PR? I guess you can after resolving the last conversation.
|
@JCZuurmond branch protection or repo setup doesn't allow me to merge this - feel free to do it. |
|
@ConstantinoSchillebeeckx : Your changes are available in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows user to set
--profiles-dirinstead of needing to set the ENVDBT_PROFILES_DIR- setting this option is more flexible than the ENV because it can be done at the command line or as an INI option.Checklist