Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web export instructions for Godot 4.3+ #74

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

PgBiel
Copy link
Contributor

@PgBiel PgBiel commented Feb 3, 2025

Supersedes #56.

Instructions still need some testing, especially on Windows (let me know if anyone would like to help testing).

Most important changes are:

  • Emscripten 3.1.62 or later is now recommended.
  • Instructions to build with and without thread support have been added.
  • We now mention the relation between Cross-Origin Isolation support for webservers and exporting with thread support.
  • We now mention that Firefox is supported for extensions (albeit maybe not with all features, though I can't name a specific missing one).
  • Other changes from updated instructions on exporting for web #56 were also inherited. In particular, the image with the export step in the editor now includes the Thread support checkbox.

Copy link
Member

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an extremely valuable write-up, thanks so much! ❤️

Thanks also for the new screenshot, that's great.

I don't have much to add content-wise, comments are mostly formatting-related. Maybe eventually you can have 2 commits (1 with the previous author using co-authored-by, one using only your additions), and I can use merge instead of squash. If you find more than 2 commits are better for logical grouping, I can of course also keep more.

src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
src/toolchain/export-web.md Outdated Show resolved Hide resolved
@Bromeon Bromeon added new-topic New content added to the book enhancement Ongoing improvements to readability, flow, etc. and removed new-topic New content added to the book labels Feb 3, 2025
@PgBiel PgBiel marked this pull request as ready for review February 4, 2025 03:17
@PgBiel
Copy link
Contributor Author

PgBiel commented Feb 4, 2025

You're welcome! I'll also thank @illegalprime for the original modifications which served as inspiration.

I've applied some changes based on reviews (and also further ideas I had) and squashed the commits into two based on authorship, feel free to take a second pass and let me know of your thoughts.

bump emscripten recommendation to 3.1.62 or later

thread support information

linting and wording improvements

updates after review
@Bromeon Bromeon merged commit 6ef92cd into godot-rust:master Feb 8, 2025
4 checks passed
@Bromeon
Copy link
Member

Bromeon commented Feb 8, 2025

Thank you very much for this great improvement! ❤️

@PgBiel PgBiel deleted the update-web branch February 8, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ongoing improvements to readability, flow, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants