-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web export instructions for Godot 4.3+ #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an extremely valuable write-up, thanks so much! ❤️
Thanks also for the new screenshot, that's great.
I don't have much to add content-wise, comments are mostly formatting-related. Maybe eventually you can have 2 commits (1 with the previous author using co-authored-by, one using only your additions), and I can use merge instead of squash. If you find more than 2 commits are better for logical grouping, I can of course also keep more.
You're welcome! I'll also thank @illegalprime for the original modifications which served as inspiration. I've applied some changes based on reviews (and also further ideas I had) and squashed the commits into two based on authorship, feel free to take a second pass and let me know of your thoughts. |
bump emscripten recommendation to 3.1.62 or later thread support information linting and wording improvements updates after review
Thank you very much for this great improvement! ❤️ |
Supersedes #56.
Instructions still need some testing, especially on Windows (let me know if anyone would like to help testing).
Most important changes are: