Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed version parsing for godot containing mono #42

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

Sythelux
Copy link

@Sythelux Sythelux commented Dec 7, 2022

I have a custom build which contains mono. I suppose it should still work with rust so I added it in. I also added a test case.

@Bromeon Bromeon added bug c: tooling CI, automation, tools labels Dec 7, 2022
@Bromeon
Copy link
Member

Bromeon commented Dec 7, 2022

Thanks! This conflicts with #30, but without more description there, I'll probably merge this PR.

This CI job failed on Windows, but it's the classic trim issue, not related to the tests here. I can fix it independently.
Disregard the Linux CI job, I need to update the headers.

@Sythelux
Copy link
Author

Thanks! This conflicts with #30, but without more description there, I'll probably merge this PR.

This CI job failed on Windows, but it's the classic trim issue, not related to the tests here. I can fix it independently. Disregard the Linux CI job, I need to update the headers.

thank you for considering. Do you need me to fix something then?

@Bromeon Bromeon merged commit 862bc55 into godot-rust:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug c: tooling CI, automation, tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants