Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLOD benchmarks #23

Merged
merged 1 commit into from
May 4, 2023
Merged

Add HLOD benchmarks #23

merged 1 commit into from
May 4, 2023

Conversation

myaaaaaaaaa
Copy link
Contributor

@myaaaaaaaaa myaaaaaaaaa commented Dec 10, 2022

Benchmarks very deep HLODs and their interactions with culling (both occlusion and frustum). Also includes some debugging features out-of-the-box for convenience sake.

Currently hangs unless NUMBER_OF_OBJECTS is set to something smaller like 1000.

Contains commits from #22 for ease of cloning.

hlod_cull.mp4

@Calinou
Copy link
Member

Calinou commented Jan 28, 2023

Currently hangs unless NUMBER_OF_OBJECTS is set to something smaller like 1000.

I wonder if this is related to godotengine/godot#70406.

@myaaaaaaaaa
Copy link
Contributor Author

Currently hangs unless NUMBER_OF_OBJECTS is set to something smaller like 1000.

It may be a good idea to wait until the fix for this is merged into Godot before merging this PR

@Calinou
Copy link
Member

Calinou commented May 4, 2023

It may be a good idea to wait until godotengine/godot#72421 is merged into Godot before merging this PR

For reference, the PR is now merged.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works. Thanks!

@Calinou Calinou merged commit 5436c12 into godotengine:main May 4, 2023
@myaaaaaaaaa myaaaaaaaaa deleted the hlod branch May 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants