-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous cleanup #26
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Feb 8, 2023
Ping me when this is ready to merge 🙂 |
@Calinou It's ready to merge 🙂 |
Calinou
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works. Results JSON for reference:
{
"benchmarks": [
{
"category": "Gdscript > Alloc",
"name": "Deep Tree",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 145.9
}
},
{
"category": "Gdscript > Alloc",
"name": "Duplicate",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 994.9
}
},
{
"category": "Gdscript > Alloc",
"name": "Fragmentation",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 1654
}
},
{
"category": "Gdscript > Alloc",
"name": "Wide Tree",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 104.5
}
},
{
"category": "Gdscript > Array",
"name": "Packed String Array",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 1594
}
},
{
"category": "Gdscript > Array",
"name": "Typed Int Array",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 2521
}
},
{
"category": "Gdscript > Array",
"name": "Typed String Array",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 3525
}
},
{
"category": "Gdscript > Array",
"name": "Untyped Int Array",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 2461
}
},
{
"category": "Gdscript > Array",
"name": "Untyped String Array",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0,
"render_gpu": 0,
"time": 3522
}
},
{
"category": "Rendering > Culling",
"name": "Basic Cull",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.6005,
"render_gpu": 1.449,
"time": 0.034
}
},
{
"category": "Rendering > Culling",
"name": "Directional Light Cull",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 1.908,
"render_gpu": 1.913,
"time": 0.036
}
},
{
"category": "Rendering > Culling",
"name": "Dynamic Cull",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 4.027,
"render_gpu": 1.712,
"time": 0.019
}
},
{
"category": "Rendering > Culling",
"name": "Dynamic Light Cull",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 1.707,
"render_gpu": 1.958,
"time": 0.018
}
},
{
"category": "Rendering > Culling",
"name": "Dynamic Light Cull With Shadows",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 2.304,
"render_gpu": 1.619,
"time": 0.018
}
},
{
"category": "Rendering > Culling",
"name": "Static Light Cull",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 1.631,
"render_gpu": 1.912,
"time": 0.017
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Box 100",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.07154,
"render_gpu": 1.215,
"time": 0.635
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Box 1000",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.3095,
"render_gpu": 1.144,
"time": 15.62
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Box 10000",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 2.738,
"render_gpu": 1.372,
"time": 888.8
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Omni 10",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.3033,
"render_gpu": 1.21,
"time": 11.92
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Omni 100",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.481,
"render_gpu": 1.292,
"time": 12.32
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Speed Fast",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.3525,
"render_gpu": 1.205,
"time": 11.41
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Speed Slow",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.3288,
"render_gpu": 1.163,
"time": 11.36
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Sphere 100",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.06782,
"render_gpu": 1.175,
"time": 0.809
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Sphere 1000",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.3273,
"render_gpu": 1.437,
"time": 11.73
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Sphere 10000",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 2.648,
"render_gpu": 3.113,
"time": 840.3
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Spot 10",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.3175,
"render_gpu": 0.8799,
"time": 11.4
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Spot 100",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.6526,
"render_gpu": 1.198,
"time": 12.16
}
},
{
"category": "Rendering > Lights And Meshes",
"name": "Stress",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 5.903,
"render_gpu": 3.113,
"time": 813.5
}
},
{
"category": "Rendering > Polygon 2d",
"name": "1000 Polygon 2d",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.08971,
"render_gpu": 0.13,
"time": 0.015
}
},
{
"category": "Rendering > Polygon 2d",
"name": "100 Polygon 2d",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.01406,
"render_gpu": 0.1752,
"time": 0.017
}
},
{
"category": "Rendering > Polygon 2d",
"name": "10 Polygon 2d",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.008327,
"render_gpu": 0.1802,
"time": 0.011
}
},
{
"category": "Rendering > Polygon 2d",
"name": "5000 Sprite 2d",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.307,
"render_gpu": 0.8095,
"time": 0.012
}
},
{
"category": "Rendering > Polygon 2d",
"name": "500 Sprite 2d",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.0377,
"render_gpu": 0.1535,
"time": 0.01
}
},
{
"category": "Rendering > Polygon 2d",
"name": "50 Sprite 2d",
"results": {
"idle": 0,
"physics": 0,
"render_cpu": 0.0103,
"render_gpu": 0.1668,
"time": 0.015
}
}
],
"engine": {
"binary_size": 116431872,
"build_type": "editor",
"version": "v4.0.2.stable.official",
"version_hash": "7a0977ce2c558fe6219f0a14f8bd4d05aea8f019"
},
"system": {
"cpu_architecture": "x86_64",
"cpu_count": 32,
"cpu_name": "13th Gen Intel(R) Core(TM) i9-13900K",
"gpu_name": "NVIDIA GeForce RTX 4090",
"gpu_vendor": "NVIDIA",
"os": "Linux"
}
}
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundled together into one PR since it's hard to keep separate branches for a codebase this small without running into self-conflicts. Depends on #22 , which the first three commits are part of.
The commits should be fairly self-explanatory. If there's any that you disagree with, let me know and I'll rebase them out.