Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Sponza benchmark #47

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Add initial Sponza benchmark #47

merged 6 commits into from
Jan 15, 2024

Conversation

franciscod
Copy link
Contributor

I've imported the scene from https://github.com/Calinou/godot-sponza/tree/4.0-dev

There are three basic benchmarks:

  • ambient only
  • directional light + shadows
  • omni lights + shadows

Sample results:

$ godot -- --run-benchmarks --include-benchmarks="rendering/sponza/*" | grep '{"benchmarks' | tee results.json | jq ".benchmarks | map(select(.results != {}))"
[
  {
    "category": "Rendering > Sponza",
    "name": "Sponza Ambient",
    "results": {
      "idle": 0,
      "physics": 0,
      "render_cpu": 0.192,
      "render_gpu": 2.474,
      "time": 0.12
    }
  },
  {
    "category": "Rendering > Sponza",
    "name": "Sponza Directional",
    "results": {
      "idle": 0,
      "physics": 0,
      "render_cpu": 0.09689,
      "render_gpu": 3.594,
      "time": 0.066
    }
  },
  {
    "category": "Rendering > Sponza",
    "name": "Sponza Omni",
    "results": {
      "idle": 0,
      "physics": 0,
      "render_cpu": 0.07761,
      "render_gpu": 7.137,
      "time": 0.06
    }
  }
]

This greatly decreases file size and speeds up loading.
@Calinou
Copy link
Member

Calinou commented Jan 15, 2024

I've pushed commits that convert Sponza to glTF + lossless WebP for smaller file sizes and faster loading speeds. The script that converts materials is also no longer required, so I've removed it.

Unused unwrap cache (due to the import mode being Static Lightmaps) was also removed, as well as specular map textures which Godot doesn't use. If we enable lightmaps later, we can commit the unwrap cache but we should wait until we actually need it.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Congratulations for your first merged pull request 🎉

@Calinou Calinou merged commit ff141de into godotengine:main Jan 15, 2024
@franciscod franciscod deleted the sponza branch January 16, 2024 01:35
@franciscod
Copy link
Contributor Author

franciscod commented Jan 16, 2024

Thank you!

For reference, this implements the first three GPU Benchmarks from #36:

  • 🟩GPU🟩 [GI,Lighting,Effects,AA,DOF]: Sponza with Ambient Light: Sponza only lit by ambient light.
  • 🟩GPU🟩 [Lighting]: Sponza with directional light: Sponza lit with a directional light and shadows.
  • 🟩GPU🟩 [Lighting]: Sponza with omni lights: Sponza lit by several omni lights casting shadows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants