Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some runtime asset importing/exporting benchmarks #80

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

OverloadedOrama
Copy link
Contributor

Adds benchmarks for runtime importing the Sponza scene as a gltf and fbx file, exporting it as gltf, importing 200 webp images and 50 ogg audio files, taken from Kenney's RPG Audio.

Basically these are runtime versions of benchmarks proposed in #36, so I'm not sure if this PR allows any of them to be ticked off, but the files introduced in this PR can later be used to tackle the startup asset importing benchmarks.

For images, I used load() instead of Image.load_from_file() because of warnings stating that using this method on images inside res:// doesn't work on export. If we don't care about this and Image.load_from_file() is preferred, let me know so I can change that.

Results on my PC

{
"benchmarks": [
{
"category": "Asset Import Export > Runtime",
"name": "Export Gltf",
"results": {
"time": 122.7
}
},
{
"category": "Asset Import Export > Runtime",
"name": "Import Fbx",
"results": {
"time": 838.7
}
},
{
"category": "Asset Import Export > Runtime",
"name": "Import Gltf",
"results": {
"time": 37.01
}
},
{
"category": "Asset Import Export > Runtime",
"name": "Import Ogg Audio",
"results": {
"time": 19
}
},
{
"category": "Asset Import Export > Runtime",
"name": "Import Webp Images",
"results": {
"time": 949.4
}
}
],
"engine": {
"version": "v4.3.beta2.official",
"version_hash": "b75f0485ba15951b87f1d9a2d8dd0fcd55e178e4"
},
"system": {
"cpu_architecture": "x86_64",
"cpu_count": 12,
"cpu_name": "AMD Ryzen 5 1600 Six-Core Processor",
"os": "Linux"
}
}

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Thanks!

@Calinou Calinou merged commit 6606590 into godotengine:main Jul 15, 2024
@OverloadedOrama OverloadedOrama deleted the runtime-importing branch August 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants