added missing link flags for mingw build #1154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! However, someone else already started PR #1082 which I think addresses the same issue. The GDExtension team provided some review there that the PR author hasn't yet addressed. If you'd like, you could pick up from where they left off? |
There is no way to take ownership of another person PR. So if I'm to continue his work I can do it only here. |
Yep, that's absolutely fine! |
|
Superseded by #1203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: When I compiled my GDExtension using mingw engine reported missing libraries, but it didn't for msvc. After some searching and debugging I found that LINKFLAGS didn't have flag for static linking. Plus the path that build system goes to build using mingw is the path msys build should go.
FIx; I just copied lines 64-72. It will affect msys builds but should not broke them, actually it should help.
When compiling in git bash
sys.platform == "win32"is true so both msys and mingw builds go into elif starting at line 40.When I tried to remove above condition to differentiate mingw and msys builds, last block of setup(else starting at line 51/60), fails with weird error and I don't have time to invest fixing it.
With condition untouched I don't know how we can access else(so does static analysis that is shipped with vscode python extension). It seems like dead code to me. I can delete this if there is no objection.