Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCons] Move the GodotCPP build to its own tool. #1190

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[SCons] Move the GodotCPP build to its own tool. #1190

merged 1 commit into from
Aug 29, 2023

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Jul 22, 2023 •
edited
Loading

This cleans up the main SConstruct file, and should allow for more control over the build system.

This is a first pass, but by moving to a Tool we should then allow calling env.GodotCPP manually from extensions, giving the possibility of changing auto-detected options.

@Faless Faless added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Jul 22, 2023
@Faless Faless requested a review from a team as a code owner July 22, 2023 18:09
@Faless Faless force-pushed the build/godotcpp_tool branch 2 times, most recently from 35334b9 to 312248c Compare July 22, 2023 18:17
dsnopek
dsnopek approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This looks awesome to me! I did a quick build with it and all seems to work as expected :-)

@dsnopek
Copy link
Collaborator

dsnopek commented Jul 31, 2023

There's conflicts after other PR merges - this needs a rebase!

adamscott
adamscott approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As @Faless said in the chat, sooner it's merged, sooner we'll be able to catch regressions and current PRs will be able to update their code.

@dsnopek dsnopek merged commit dd9586b into godotengine:master Aug 29, 2023
11 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Aug 29, 2023

Thanks!

@Faless Faless deleted the build/godotcpp_tool branch August 29, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faless @dsnopek @adamscott