Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generated version header #1193

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

Zylann
Copy link
Collaborator

@Zylann Zylann commented Jul 26, 2023

Generates a core/version.hpp file with macros similar to Godot's core VERSION_*. This allows to do conditional compilation in case of compatibility breakage between Godot versions.

@Zylann Zylann requested a review from a team as a code owner July 26, 2023 22:18
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great to me :-)

@dsnopek
Copy link
Collaborator

dsnopek commented Aug 11, 2023

Discussed at the GDExtension meeting. There was some discussion around the defines being prefixed with GODOT_ versus their counterparts in Godot itself, but we think this is fine as-is.

@dsnopek dsnopek merged commit 5eebc6b into godotengine:master Aug 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants