Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remaining component-wise min/max functions to Vector* #1197

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips added this to the 4.x milestone Aug 3, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner August 3, 2023 15:34
@AThousandShips AThousandShips added the enhancement This is an enhancement on the current functionality label Aug 7, 2023
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! The implementations match their Godot counterparts.

Since this doesn't rely on the Godot PR, I think it'd be fine to merge this even before that PR is merged.

Copy link

@m4rr5 m4rr5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new functions look good to me.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godotengine/godot#73265 probably should be ported as well.

Or maybe we can mod the engine files (math types and templates) to be buildable in both godot-cpp and the engine (similar to the TextServers) and sync them by just copying files as is.

@dsnopek
Copy link
Collaborator

dsnopek commented Aug 16, 2023

Thanks!

godotengine/godot#73265 probably should be ported as well.

Or maybe we can mod the engine files (math types and templates) to be buildable in both godot-cpp and the engine (similar to the TextServers) and sync them by just copying files as is.

I think we can address/explore those in follow-up PRs

@dsnopek dsnopek merged commit 7ed7a84 into godotengine:master Aug 16, 2023
11 checks passed
@AThousandShips
Copy link
Member Author

Thank you!

@AThousandShips AThousandShips deleted the vec_elem branch August 17, 2023 05:44
@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants