Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clang deprecated builtins #1211

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix Clang deprecated builtins #1211

merged 1 commit into from
Aug 16, 2023

Conversation

adamscott
Copy link
Member

It seems that Clang and GCC have different interpretations of certain builtins. So this PR fixes the "deprecated" builtins for Clang, but keeps them for GCC.

Fixes #1210

@adamscott adamscott requested a review from a team as a code owner August 15, 2023 15:52
@adamscott adamscott added this to the 4.2 milestone Aug 15, 2023
@adamscott adamscott force-pushed the fix-deprecated-builtins-clang branch from 5313f06 to 0334915 Compare August 15, 2023 16:01
@dsnopek
Copy link
Collaborator

dsnopek commented Aug 15, 2023

Thanks!

Looking at cowdata.h in Godot, it's using the functions from the C++11, ie std::is_trivially_destrucible(), etc. Perhaps it would be better to sync up with Godot, rather than adding the #ifdefs?

@adamscott adamscott force-pushed the fix-deprecated-builtins-clang branch from 0334915 to 1a49895 Compare August 15, 2023 22:49
@adamscott
Fix Clang deprecated builtins
5c26284 
It seems that Clang and GCC have different interpretations of certain
builtins. So this PR uses std <type_traits> functions just as cowdata.h
does in the godot project.
@adamscott adamscott force-pushed the fix-deprecated-builtins-clang branch from 1a49895 to 5c26284 Compare August 15, 2023 22:50
@adamscott
Copy link
Member Author

Looking at cowdata.h in Godot, it's using the functions from the C++11, ie std::is_trivially_destrucible(), etc. Perhaps it would be better to sync up with Godot, rather than adding the #ifdefs?

Done!

@akien-mga akien-mga added bug This has been identified as a bug and removed usability labels Aug 16, 2023
@akien-mga akien-mga merged commit 524bbd3 into godotengine:master Aug 16, 2023
11 checks passed
@akien-mga
Copy link
Member

Thanks!

@adamscott adamscott mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

[Clang] Use of deprecated builtins
3 participants
@adamscott @dsnopek @akien-mga