[SCons] Fixed crashes in several scripts #1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After moving most of the code from
SConstruct
togodotcpp.py
(63755b2) some methods are no longer detected by the interpreter and require a call through the environment (that's how I understood it).Also, the import of
UserError
was not moved.Now these commands will not lead to crashes:
And the
generate_bindings
argument works againFixes #1236
The
Exit()
method should also be called fromenv
and not return 0 on errors.