Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCons] Fixed crashes in several scripts #1237

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

DmitriySalnikov
Copy link
Contributor

After moving most of the code from SConstruct to godotcpp.py (63755b2) some methods are no longer detected by the interpreter and require a call through the environment (that's how I understood it).
Also, the import of UserError was not moved.

Now these commands will not lead to crashes:

scons gdextension_dir=gdextension.file
scons custom_api_file=gdextension
scons compiledb_file=wrong/path_to.json

And the generate_bindings argument works again

scons generate_bindings=yes

Fixes #1236

The Exit() method should also be called from env and not return 0 on errors.

@DmitriySalnikov DmitriySalnikov requested a review from a team as a code owner September 9, 2023 09:55
@dsnopek dsnopek added bug This has been identified as a bug cherrypick:4.1 labels Sep 9, 2023
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works great in my testing

@dsnopek dsnopek merged commit 80f98de into godotengine:master Sep 9, 2023
11 checks passed
@DmitriySalnikov DmitriySalnikov deleted the fix-scons-crashes branch September 9, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'AlwaysBuild' is not defined when using generate_bindings=yes
2 participants