Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ERR_FAIL_COND with ERR_FAIL_NULL where applicable #1242

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Replace ERR_FAIL_COND with ERR_FAIL_NULL where applicable #1242

merged 1 commit into from
Sep 20, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 12, 2023 •
edited
Loading

@AThousandShips AThousandShips added the enhancement This is an enhancement on the current functionality label Sep 12, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Sep 12, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner September 12, 2023 18:22
dsnopek
dsnopek approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dsnopek dsnopek merged commit b1fd1b6 into godotengine:master Sep 20, 2023
11 checks passed
@AThousandShips AThousandShips deleted the null_check branch September 20, 2023 12:44
@AThousandShips
Copy link
Member Author

Thank you!

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 9, 2023

Cherry-picked for 4.1 in PR #1261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rburing rburing rburing approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@AThousandShips @dsnopek @rburing