Use the new string_name_new_with_latin1_chars function to improve StringName construction performance
#1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tringName construction performance
dsnopek
added
the
enhancement
dsnopek
added
the
topic:gdextension
akien-mga
reviewed
Oct 12, 2023
| @@ -458,8 +458,9 @@ String operator+(char32_t p_char, const String &p_str) { | |||
| return String::chr(p_char) + p_str; | |||
| } | |||
|
|
|||
| StringName::StringName(const char *from) : | |||
| StringName(String(from)) {} | |||
| StringName::StringName(const char *from, bool p_static) { | |||
There was a problem hiding this comment.
Side question, but why do String and StringName definitions live in a char_string.cpp file instead of string.cpp and/or string_name.cpp? Sounds like it was created for CharString (which is an implementation detail of String).
There was a problem hiding this comment.
Probably mild laziness :-)
Most of String and StringName are automatically generated code, they just have a couple of handwritten methods, whereas as all of CharString is handwritten. So, I'm guessing someone just thought, "ah, it's string-related, I'll just throw these in char_string.cpp" rather than making new handwritten string.cpp and string_name.cpp files.
akien-mga
approved these changes
Oct 12, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the changes from PR godotengine/godot#78580